From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +P4LG4cDnGFWUwEAgWs5BA (envelope-from ) for ; Mon, 22 Nov 2021 21:54:31 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UPeXFocDnGGrQAAAbx9fmQ (envelope-from ) for ; Mon, 22 Nov 2021 20:54:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1C87B31080 for ; Mon, 22 Nov 2021 21:54:31 +0100 (CET) Received: from localhost ([::1]:49122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpGKb-0001Ed-6n for larch@yhetil.org; Mon, 22 Nov 2021 15:54:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpGJz-0001ET-E3 for emacs-orgmode@gnu.org; Mon, 22 Nov 2021 15:53:52 -0500 Received: from [2607:f8b0:4864:20::42a] (port=39766 helo=mail-pf1-x42a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpGJx-0000yO-P6 for emacs-orgmode@gnu.org; Mon, 22 Nov 2021 15:53:51 -0500 Received: by mail-pf1-x42a.google.com with SMTP id i12so17253868pfd.6 for ; Mon, 22 Nov 2021 12:53:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:cc:subject:in-reply-to:references:date:message-id :mime-version:content-transfer-encoding; bh=e0QwAntGQMRCMxacPD4UcV12SkFTTZvXa1QLDNC2jZM=; b=gyLzF8kRaE8SkUzBJOmKnJqtre4J6WE8hQ6PnOkJYrd91Mg8HW+/FhI/O7FA5aCztr JQbvSIZ6Dg4TqDhgTDBWPJ/cMoGyFSH6t/8tr2iege7vbxMxv6GOycAtu9ALCAkcNBox BIFZerNjoqlPDof0+GhqTt8hsnMZUE8Sw2djA2PObAZxABU70OjYhWN6mLbbTzLHq1fr OTnRq6WEm3WcCq88eQnCSUBKp/BHn5C+z9VX0sibBj+CyTpK1cYS0oA1Gsj+m6fXQ69d 4vuaoO1oFhAYk6PbJUuDLtBub4xmHJVCWYUfHYRcF4TScsHKDNbhjg7uyBug/eSa4M6N FukA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:cc:subject:in-reply-to:references :date:message-id:mime-version:content-transfer-encoding; bh=e0QwAntGQMRCMxacPD4UcV12SkFTTZvXa1QLDNC2jZM=; b=6RNok4jJtQVKcYbCvP1uv9QusBTAKqlPTmpSJDHmnW2ZrdyM1UvlVIQQ4VFo98d9hA u34m1A0eSGscYO8o/u1U+J05heSBdeLImqlwz/2OhECN9QRQ/nhznxOB0f8v5jdEE159 CkA/Us4WlvJi25gRvkXe+sVYWIz7f1opA5PqtofvTelFXHPl7tDGVVRTrJJubpfebnd1 orxHWIZnAmH+eb+PUZRaVLU740YYQkNUGoF3JVxMNzixGicQ4J93aSgs04NyPLcxHptp zetJOq/xMJqvVjQ7uIU7d93La3iPCnTGw9Uioi6pB9pBAmUp1nsT/Xu+bfl8iHgqXCMa AJgA== X-Gm-Message-State: AOAM531/LwDTH/UNtXnLMofnAju3qfxd6BF3uM4eY+arb1tgaEuuLEJZ EmqyQKCr8fA82Cv50g9v5t9/xr4PLzA= X-Google-Smtp-Source: ABdhPJywK2Gm4exo9Ey1nWCvzHI3wTcqLBBzR43pfhmUDu6StklLWWpRzwfZ0A4x8M5W067a8TuuiA== X-Received: by 2002:a63:1f0e:: with SMTP id f14mr35479965pgf.242.1637614427357; Mon, 22 Nov 2021 12:53:47 -0800 (PST) Received: from ryzen3950 (c-208-82-98-189.rev.sailinternet.net. [208.82.98.189]) by smtp.gmail.com with ESMTPSA id mg12sm19521056pjb.10.2021.11.22.12.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Nov 2021 12:53:46 -0800 (PST) From: Matt Huszagh To: Timothy Subject: Re: [PATCH] Fix regex for determining image width from attribute In-Reply-To: <87wnl05ag6.fsf@gmail.com> References: <87czmtuy0p.fsf@gmail.com> <87ilwl71gh.fsf@gmail.com> <87a6hxuw0y.fsf@gmail.com> <877dd07fnb.fsf@gmail.com> <8735noqig0.fsf@gmail.com> <87wnl05ag6.fsf@gmail.com> Date: Mon, 22 Nov 2021 12:53:45 -0800 Message-ID: <87y25fq5d2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::42a (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=huszaghmatt@gmail.com; helo=mail-pf1-x42a.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637614471; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=e0QwAntGQMRCMxacPD4UcV12SkFTTZvXa1QLDNC2jZM=; b=Ro+yKQtJG9swD5jFxHbEAeyg44+IAtreUIJg54n7A30SX7Io4+Y9QR9v9Sd8d8DRb9ZpZb JDNSNjWwtk/1sytW3XsOWy4Bdaw0smuOSOjMY/WR3/1lxeUZKuaylFaXTAXEsL90qIfv47 dhtB+U4Nikjc0Njxn7RIM67BwOWIP4JIZgtvX82ZD55HP3jghfwE6msFS/RJRtM4nc2rBh Tud+k+tyFAjR4d9TE5WrzuvawRiDLfns/kAOzgeISmAuqWxEQVCpwTqw4+7YJhlHAaQcSS 5Cg7AL4ZtLeRpQJ9rse8pNzfYXr0//Aus/ph8jpIP9hjUJnK1VbUTQpDw5y21g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637614471; a=rsa-sha256; cv=none; b=c/Iz6N4Erqb0ROegQHnlH1C2mkW+Y+KDjJo3w2FLv7uh6bSwYmXEpfhORvEn+FOJAcTIAl pOqhkYvXBW2FS1NUX6tTd2/KGczHXlWl+/ynKJWYaGCzCBXhBq1bT1ivoGQvr7V/ygAEHL XHYO/OIEnrBOXFI8hrcwsqBEZcS/lZZL9beGqnzVWZAn8H3/LPXEQM10gkpLDKQq4iUVxj OA19Ce8UuFUeAQtAJITW/+qhp57WMN6zq86e66K5x2H2mk9wsbqpppsgh9mL4HE25MId9F PUdMFI3Rbz1hRHfBnT8KsRUNrLOg2EfweMMGW3a80MZhFnYfb0JA1ouP6JrJqA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=gyLzF8kR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.78 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=gyLzF8kR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 1C87B31080 X-Spam-Score: -1.78 X-Migadu-Scanner: scn1.migadu.com X-TUID: IPkHgKzaOtLf Timothy writes: > I=E2=80=99ve just pushed the change I described in 4514a32. This improves= the > interpretation of :width attributes and makes a value of =E2=80=9Ct=E2=80= =9D work as discussed. > I have not prioritised #+attr_org for now, but that sounds like a change = we > could make in the future. Thanks Timothy. However, I think this change may have some issues. It seems that it unbalances parentheses. This also no longer sets width (so, e.g., (floatp width) won't work). Maybe attr-width was intended to be renamed to width? Are you seeing the same? I've got an implementation for prioritizing #+attr_org, but I want to make sure your commit goes in the right way before I submit that. Matt