From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mFL7FLqEn2H7BgEAgWs5BA (envelope-from ) for ; Thu, 25 Nov 2021 13:42:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wOusELqEn2G3SQAAbx9fmQ (envelope-from ) for ; Thu, 25 Nov 2021 12:42:34 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E0BED5A57 for ; Thu, 25 Nov 2021 13:42:33 +0100 (CET) Received: from localhost ([::1]:48132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqE5B-00014m-3z for larch@yhetil.org; Thu, 25 Nov 2021 07:42:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqE1w-00012X-GQ for emacs-orgmode@gnu.org; Thu, 25 Nov 2021 07:39:24 -0500 Received: from [2607:f8b0:4864:20::535] (port=38593 helo=mail-pg1-x535.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqE1u-0002Gj-Md for emacs-orgmode@gnu.org; Thu, 25 Nov 2021 07:39:12 -0500 Received: by mail-pg1-x535.google.com with SMTP id s137so5139549pgs.5 for ; Thu, 25 Nov 2021 04:39:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=EDje/kSTScngN0bvYxZlmH4tAM8EokdQX/x/sLitctE=; b=Epo7d2ey3dHqxbXYDDyiM39XlOqz22i20r0PK/kwxtvfG+jsmOrsQDQW8cF+G5ym/l zHUmMDRButtXVy2Tg+m1+dEJuVUGCuAK+0SKRQD04N5/N1tlRUJT7BWhHaeU9qOSGHnI 0S8tdJFjzi+DP/I7vo+sVeqOE9JC7wqqYmO6SEGcuhM/tR9uanoA10KsXJpWYWWkFI/n FXPImBRFL2xlM1QdtZJJcN6Hbohqqm0dKfTj2R17UCCQc2g3LwMV6k87ga5+HvCGpKFh taFpxf/EFWt0pNu9NCVHMgMI1DjWOfh4CQPbC9Xsr3A10TZGNOl2xn1eB2cfHx2BwwdT L8LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=EDje/kSTScngN0bvYxZlmH4tAM8EokdQX/x/sLitctE=; b=y1LR4QAEJLDYysxl1Okuv0yI9+37lUw5EZWpv3xeB9enh4y6/kLwckbIWojgzJ+P77 nGOvtV1Ij8CZt01WBHVHV4l3BP00nONmrmsplzQNDoTv6EVTl37M0scR/EI+XKnPBZ7c BbKvEzO8DDKo5fDTsJRaKCg1yjf1307eYNsl2ZdlNTjU72GfLGEsrv6MIBHeSlNB/qCT oAoUZaXx7qLRdDS+kT7jN6hIoeZJjYMgbCUXC3F1BNxyP//CSJgtb9BbZsmacTrN9XIW g5V6AjjTA6YPpEucFGY27X8wsVkfcAlZF32NsLL6k2TE1GGAc+kvdDQXUEDuSJg8mTTK Inow== X-Gm-Message-State: AOAM533kmVPR4NYvrhWyYgo6J6zS47Tcc0HW90L9weEJs8RE2vjMfoDT 2Og2om+wZVXVh1fhkOYd5AU= X-Google-Smtp-Source: ABdhPJzMXg1xljAyByelpKq41EhUUFIBY0piAoWXrTXXrqTEkeXxh+AGvelgrOAzklUqdyKbnANlRA== X-Received: by 2002:a62:884c:0:b0:49f:9947:e5cd with SMTP id l73-20020a62884c000000b0049f9947e5cdmr13885663pfd.45.1637843949262; Thu, 25 Nov 2021 04:39:09 -0800 (PST) Received: from localhost ([103.125.234.111]) by smtp.gmail.com with ESMTPSA id d17sm3332700pfj.215.2021.11.25.04.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 04:39:08 -0800 (PST) From: Ihor Radchenko To: guillaume@gbuisson.com Subject: Re: [PATCH] Fix ob-plantuml over TRAMP In-Reply-To: References: Date: Thu, 25 Nov 2021 20:40:35 +0800 Message-ID: <87y25c1k8s.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::535 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=yantar92@gmail.com; helo=mail-pg1-x535.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637844153; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=EDje/kSTScngN0bvYxZlmH4tAM8EokdQX/x/sLitctE=; b=XsX+fZFtbLQ4YJhGExzgupe86QjkMqc6/l2iBkSeQRIYsqXjsBkFoE/ftpI2wK26y5y4Qy /I7dTgiZcLEA3TBpHuXKCa03KyVAKPmBWHO7lkcaZDSbDHZNdkJiTv5F3uRAIcI64twlTC d8RWT/GiOmbifvNNJ/z1UZfUeyYzMQrpAMFUUGIb8ewRBqTnN/O27xxM1Tmka394KuxAGM bsxWfQXjwQ7WQkDrZSqgHBrIjxtAHbSIpGcAbt6iM8Wvi7OlSs4Z8lUPYvWhwUJbCu7A38 YSgH5eL/4AI7KoCZ1MmlWUXGrJH1zkj4Z2BtOa0pfsO3xk+IkfdJ4QRACVS3iQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637844153; a=rsa-sha256; cv=none; b=k+gsCHquQEtGcEiStRjuuZC+IjPdkqk9Elxd+bPXKSWdUoV9fUgYRv3kzQUIFvTBj6lAax G08EjJGtGVKTajHIYJ5NlBXhY7GoBIXmpRPHax5NeFhH5Q8Trs6XhWxJHD7MH9t/Mg7QaH nvGNZ0AhjsLqlg1A5UZ07x4tWg6hS+Ca7WuVNBAl6ZiHRJA0bVstEXMeoylAUiOnT5LCxH 54smqY91fPQ0TglCJaOVoTkZGVEryK2kn2vI058DqDFIenYjL+TX30grnDUxJHYf7QnEBY Aj9bYu/7vAe24NLAkefgx73zeI+GM5MIZv85ZN9tQmuIX9htP3QEG03KJ5QfNw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Epo7d2ey; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.59 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Epo7d2ey; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E0BED5A57 X-Spam-Score: -3.59 X-Migadu-Scanner: scn1.migadu.com X-TUID: i9eWQc8fuA/F guillaume@gbuisson.com writes: > It seems to me that there is a redundant check which uses `file-exists-p` even if using TRAMP, the plantuml jar is located on the remote server, so > it fails with an error even though the command to actually render the diagrams works fine. I disagree that the check is redundant. It is still a good idea to check if plantuml jar exists on server itself. Another question is how to make `file-exists-p' work with TRAMP. > The patch I propose involves keeping this check but moving it so it only generates a message instead of failing the whole generation process, > doing so allows to restore the functionality and I can finally generate my sequence diagrams over TRAMP. Your patch will break legitimate check for people running plantuml locally. A better way would be checking default-directory and if we are in a remote server, using appropriate check working over TRAMP. Best, Ihor