From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id sBsqGVvaXWZ+PwAAqHPOHw:P1 (envelope-from ) for ; Mon, 03 Jun 2024 16:59:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id sBsqGVvaXWZ+PwAAqHPOHw (envelope-from ) for ; Mon, 03 Jun 2024 16:59:39 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 59C1A3049E for ; Mon, 3 Jun 2024 16:59:39 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sE99A-0004hn-SA; Mon, 03 Jun 2024 10:58:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sE998-0004hA-Fr for emacs-orgmode@gnu.org; Mon, 03 Jun 2024 10:58:50 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sE996-0001tC-2D for emacs-orgmode@gnu.org; Mon, 03 Jun 2024 10:58:50 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9C1BB240027 for ; Mon, 3 Jun 2024 16:58:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1717426725; bh=Hv/Cx0rV8FZ3VYDDDr8WuVUcjsjou3W5tqfZNdvLhpo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=XonN+BWXjpFUDFRJd+DQrZ3oZVu6X8A/QJr342N6SEfGa4iD5nE0fA+fuQL2dlQbZ jQfdb6PZKC5DStTj1kQpmTXhMsBbxXa+REe7Zp+HLHPpIv0TwfwWxxnaIRq/P7ce9E lHfyuIQ4l/6VqiS5F693zgkBpZ5RB8Cco7YXfDW8k3SQNcSO6ecEtckQeWA1G8EYRS xTdZoOSq3I3jqy/7ctgONSzwzs+rUdARSvqP9EuXsMDmmKNgAZ5mIGVFI/DLOpjDg4 hk5/yz5xCm/rin/8gN2+ZFQcmpSg5Znvs6x6gZlA+GaczaihfwtCK3dGZ4fAMPjT96 k7p+U572Q/gOg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VtH111g1yz9rxM; Mon, 3 Jun 2024 16:58:45 +0200 (CEST) From: Ihor Radchenko To: Kyle Meyer Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-test: Fix zone-dependent miscalculation of days of week In-Reply-To: <87le3o5ogg.fsf@kyleam.com> References: <87le3o5ogg.fsf@kyleam.com> Date: Mon, 03 Jun 2024 15:00:24 +0000 Message-ID: <87y17mm5pz.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 59C1A3049E X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -4.00 X-Spam-Score: -4.00 X-TUID: ql4sO2a86zJI Kyle Meyer writes: > Three clock tests are failing on my end: > > FAILED test-org-clock/clock-drawer-dwim > FAILED test-org-clock/org-clock-timestamps-change > FAILED test-org-clok/org-clock-update-time-maybe > > Those stem from org-test-day-of-weeks-{abbrev,full} not having the > expected value. Those variables are supposed to list Sunday through > Saturday in the machine's locale. Here's what I see on my end: > > org-test-day-of-weeks-full=E2=80=99s value is > ["Saturday" "Monday" "Monday" "Tuesday" "Wednesday" "Thursday" > "Friday"] > > The patch below fixes the issue on my end. In addition to my usual > locale, I tested it with another one (de_BE.utf8), and all the tests > passed. > ... > (defconst org-test-day-of-weeks-seconds > - [121223891 ; Sun > - 30000000 ; Mon > - 2222222 ; Tue > - 500000 ; Wed > - 1000 ; Thu > - 89173 ; Fri > - 666666666] ; Sat > + [302400 ; Sun > + 388800 ; Mon > + 475200 ; Tue > + 561600 ; Wed > + 648000 ; Thu > + 734400 ; Fri > + 820800] ; Sat I suspect that the failures are because of your timezone. If my guess is right, there will always be some timezone where a given number seconds from epoch is a different day... I am not sure how to address this problem. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at