From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id iLMrJZRucGY0kQAA62LTzQ:P1 (envelope-from ) for ; Mon, 17 Jun 2024 17:12:52 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id iLMrJZRucGY0kQAA62LTzQ (envelope-from ) for ; Mon, 17 Jun 2024 19:12:52 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ESNISRis; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718644372; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=O3F1kOKDzFo9YzWzVxPKFLEeV416qPK+wLLnnabe5Qs=; b=CFZVeYFfUFAvl3zuBaA53SDmQwH3FMQifEyAPhh/1wQ9ce2q/Owzxl001jcYHJB6a+U+rT LW15/zZz776ro2zrgEHZsV/52qVih+6JACWyYiHcsFNR5KNueOyP5I47E/8GAm2aXy+61p 7kzIOQq9ZBmvrhhkW+xcm1JYk46UGE/gEW37XKsFUEXHyOWB46QFqqaLhItB9thV4zfyu9 a/OLigQzvoKiOTWQa6MO0P7qWiIYxs6i2ScOv4CeKuo5xm8GFcNofR0NEF9bzngJSTlDJS DhPKQUB6DlzYnZ/KlLvtll3AoD+lMGaPHQKyLmsJaEj4vNm7Wk7N98qXBxhKsw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ESNISRis; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718644372; a=rsa-sha256; cv=none; b=sAjKkGUZQo8LQhksfWAj3BbbTGuIvlv0089/YpHkcoCP4hqt1hKqnRWbf3vwnOItiMa0ga hEBQI8XuHNJSeq9iK6HZUMY4neRoZqeNFSRcT9t0oiOzL+NJvIUCZEkgmrRu9wZ33UN8Vv tlYusbmn/bkrGf3NTBGJQVk2Q6DLMBFzXUuTeqXN6Fhwya4D7uYxNKtOW3AZ/yF4iN5x0q cwMn2JetPYbSOFwXKqU4DefxkCg75/W93gX22yKwXqy9XjcCkQDiY4jBzVV+mUef6SDzja tExO7IkYd/Yn5q29KshEhNdbs7XVTzmlG0uTHJgvAONYXxv1CC9RYkjwj3BpIg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 83E9F868E for ; Mon, 17 Jun 2024 19:12:52 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJFu2-0008RP-05; Mon, 17 Jun 2024 13:12:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJFtz-0008R5-Qx for emacs-orgmode@gnu.org; Mon, 17 Jun 2024 13:12:19 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJFty-00045Y-7L for emacs-orgmode@gnu.org; Mon, 17 Jun 2024 13:12:19 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id DCBAB240103 for ; Mon, 17 Jun 2024 19:12:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718644335; bh=tYPiPTuTe721llqamV3JmVoVOWwUwz9t5o3Rt6+GOX0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=ESNISRisij3GzZGaj06Dh0fUMxRATjAeShfEsOzoMmcuamWmjJWmS0BUVdEPehpqV Ibuwfyv5hCFOI1ybl9UUF42h9eSfTmqNvvmq2bDpNw40i2flo1NqT6vJiR/Hlyy5Nm zguaekdpOWee7rgDJjI/akH+vPAvauxMQlypV0exz+tSC/UWJ6OZ0gaiCc/H7Zsr94 n+xtNHF2+UxkSNy5Qs4xABR8bab2vo9262v3tol6cQzqJrQPZYR4/Mc8AWUimAV9pt Jgk15KGm6Lly7HHaDR0Ua4xMDBT/MYOWaNaoHh1hnXL7kbzgAB8HIQ+cuhcEFcc2+p kfD73J2K2RogQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W2xJZ63jYz9rxP; Mon, 17 Jun 2024 19:12:14 +0200 (CEST) From: Ihor Radchenko To: Visuwesh Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] org-plot: Unable to use text xtics with type:2d (+ more) [9.7-pre (N/A @ /home/viz/lib/emacs/straight/build/org/)] In-Reply-To: <87le3440qe.fsf@gmail.com> References: <87cypbjw50.fsf@gmail.com> <871q5rv1qy.fsf@localhost> <8734q7jfes.fsf@gmail.com> <87wmmu72pu.fsf@localhost> <87zfrp4939.fsf@gmail.com> <87ikyd48f8.fsf@gmail.com> <87le36ilf0.fsf@localhost> <87le3440qe.fsf@gmail.com> Date: Mon, 17 Jun 2024 17:13:59 +0000 Message-ID: <87y173a3vs.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -9.57 X-Migadu-Queue-Id: 83E9F868E X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -9.57 X-TUID: KIPRyMWZqaQH Visuwesh writes: >>> - (type (assoc (plist-get params :plot-type) >>> - org-plot/preset-plot-types)) >>> + (type (cdr (assoc (plist-get params :plot-type) >>> + org-plot/preset-plot-types))) >>> gnuplot-script) >> >> This may break the existing customization. >> Later in the function, TYPE is used as an argument for >> `org-plot/gnuplot-term-extra' and `org-plot/gnuplot-script-preamble'. >> Some users may have these two custom options adjusted to the older >> calling convention. >> >> To not break things, we should pass the full `assoc' to these functions. > > If you meant org-plot/gnuplot-script eventually calling these functions, > then I don't see how the above change will break things. Even in > org-plot/gnuplot-script, TYPE passed to both these user options are > > (let* ((type-name (plist-get params :plot-type)) > (type (cdr (assoc type-name org-plot/preset-plot-types)))) > > so there should be no harm done by the above change since TYPE is not an > argument taken by org-plot/gnuplot-script. Agree. I accidentally moved away from the function that is actually being changed to org-plot/gnuplot-script that has nothing to do with TYPE binding you are changing in the patch. So, your code is ok here. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at