emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Anoop GR <anoopemacs@gmail.com>
Cc: emacs-orgmode@gnu.org, Bastien Guerry <bzg@gnu.org>
Subject: Re: ob-clojure breaks tangling of comments using org-babel-tangle for clojure source code blocks
Date: Wed, 16 Oct 2024 19:49:58 +0000	[thread overview]
Message-ID: <87y12n6d5l.fsf@localhost> (raw)
In-Reply-To: <CACabEsQJv746XvkLTfom2rgcnQAfHT-YDCOuTPAx5gVRK1wGpQ@mail.gmail.com>

Anoop GR <anoopemacs@gmail.com> writes:

> Comments in org babel clojure blocks are not tangled out.
> ...

This seems to be intentional (commit b1f564b4b6):

In ob-clojure.el, we have:

	 ;; Remove comments, they break (let [...] ...) bindings
	 (body (replace-regexp-in-string "^[ 	]*;+.*$" "" body))

It seems that there is some weirdness in Clojure interaction with
comments inside let [...] clauses.

I am not familiar enough with closure to comment on this. Maybe you know
more?

CCing Bastien, the author of the commit.

I guess that we may leave the comments intact if the code block does not
have :var.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  parent reply	other threads:[~2024-10-16 19:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 17:43 ob-clojure breaks tangling of comments using org-babel-tangle for clojure source code blocks Anoop GR
2024-10-15 17:51 ` Anoop GR
2024-10-15 17:52   ` Anoop GR
2024-10-15 17:53     ` Anoop GR
2024-10-16 19:49 ` Ihor Radchenko [this message]
2024-10-17 13:42   ` Anoop GR
2024-10-17 17:59     ` Ihor Radchenko
2024-10-18 10:18       ` Anoop GR
2024-10-18 17:23         ` Ihor Radchenko
2024-10-18 20:16           ` Anoop GR

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y12n6d5l.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=anoopemacs@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).