From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Lundin <mdl@imapmail.org>
Subject: Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view
 back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Date: Fri, 04 Feb 2011 20:20:34 -0500
Message-ID: <87wrlfl1jx.fsf@fastmail.fm>
References: <sa3ei8b1sbv.fsf@cigue.easter-eggs.fr>
	<20110201115210.6AD9A8783@myhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=43190 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PlWpL-0002ZK-5c
	for emacs-orgmode@gnu.org; Fri, 04 Feb 2011 20:20:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lundin@fastmail.fm>) id 1PlWpI-0002S0-R1
	for emacs-orgmode@gnu.org; Fri, 04 Feb 2011 20:20:39 -0500
Received: from out1.smtp.messagingengine.com ([66.111.4.25]:37274)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lundin@fastmail.fm>) id 1PlWpI-0002Rk-Ip
	for emacs-orgmode@gnu.org; Fri, 04 Feb 2011 20:20:36 -0500
In-Reply-To: <20110201115210.6AD9A8783@myhost.localdomain> (Bastien Guerry's
	message of "Tue, 1 Feb 2011 12:52:10 +0100 (CET)")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bastien Guerry <bzg@altern.org>, Julien Danjou <julien@danjou.info>
Cc: emacs-orgmode@gnu.org

Bastien Guerry <bzg@altern.org> writes:

> Patch 543 (http://patchwork.newartisans.com/patch/543/) is now "Accepted".

>> * org-agenda.el (org-agenda-list): Use org-agenda-current-span as a
>> possible default span if it is set.
>> 
>> Signed-off-by: Julien Danjou <julien@danjou.info>
>> ---
>>  lisp/org-agenda.el |    5 ++++-
>>  1 files changed, 4 insertions(+), 1 deletions(-)
>> 
>> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
>> index 0cd620c..0d695b5 100644
>> --- a/lisp/org-agenda.el
>> +++ b/lisp/org-agenda.el
>> @@ -3450,7 +3450,10 @@ given in `org-agenda-start-on-weekday'."
>>    (setq org-agenda-last-arguments (list include-all start-day span))
>>    (org-compile-prefix-format 'agenda)
>>    (org-set-sorting-strategy 'agenda)
>> -  (let* ((span (org-agenda-ndays-to-span (or span org-agenda-ndays org-agenda-span)))
>> +  (let* ((span (org-agenda-ndays-to-span (or span
>> +					     org-agenda-current-span
>> +					     org-agenda-ndays
>> +					     org-agenda-span)))
>>  	 (today (org-today))
>>  	 (sd (or start-day today))
>>  	 (ndays (org-agenda-span-to-ndays span sd))
>> -- 

This patch breaks custom commands --- i.e., if one binds org-agenda-span
in a custom command, it seems to be overridden by the span of whatever
agenda command one last called (i.e., org-agenda-current-span).

Steps to replicate:

1. (setq org-agenda-span 'day)

2. M-x org-agenda-list

3. Check the value of org-agenda-current-span => day

4. Call the following custom command:

(setq org-agenda-custom-commands
      '(("c" "Calendar" agenda ""
	 ((org-agenda-span 'week)
	  (org-agenda-start-on-weekday 0)	
	  (org-agenda-time-grid nil)
	  (org-agenda-entry-types '(:timestamp :sexp))
	  (org-agenda-prefix-format " %-12:t ")
	  (org-deadline-warning-days 0)
	  (org-agenda-include-all-todo nil)
	  (org-agenda-repeating-timestamp-show-all t)
	  ))))

This results in only a day view because org-agenda-current-span is still
'day.

Best,
Matt