BUG typo in babel.org?

BUG typo in babel.org?

[Andreas Röhler]

in org-mode/testing/examples/babel.org

a noweb-example1 as called, which seems not defined

Andreas

Re: BUG typo in babel.org?

[Bastien]

Hi Andreas,

Andreas Röhler <andreas.roehler@easy-emacs.de> writes:

> in org-mode/testing/examples/babel.org
>
> a noweb-example1 as called, which seems not defined

Can you help suggesting a fix (ideally as a patch) and
explaining why it is needed?

Thanks,

-- 
 Bastien

Re: BUG typo in babel.org?

[Andreas Röhler]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Am 26.02.2013 11:41, schrieb Bastien:
> Hi Andreas,
>
> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>
>> in org-mode/testing/examples/babel.org
>>
>> a noweb-example1 as called, which seems not defined
>
> Can you help suggesting a fix (ideally as a patch) and
> explaining why it is needed?
>
> Thanks,
>

Hi Bastien,

as I'm still exploring org-mode and the way to write tests for,
please have a look IIUC,

Andreas

[-- Attachment #2: babel.org.diff --]
[-- Type: text/x-patch, Size: 706 bytes --]

commit 798372693b754e7a5d5311b8e0b8b79f70005212
Author: Andreas Roehler <andreas.roehler@online.de>
Date:   Tue Feb 26 12:01:27 2013 +0100

    define noweb-example1 in org-mode/testing/examples/babel.org
    
    noweb-example1 as called later on, but seems not defined
    
    TINYCHANGE

diff --git a/testing/examples/babel.org b/testing/examples/babel.org
index 7c30ab2..8fad7f0 100644
--- a/testing/examples/babel.org
+++ b/testing/examples/babel.org
@@ -8,6 +8,11 @@
 
 #+name: noweb-example
 #+begin_src emacs-lisp :results silent :exports code
+  (message "expanded")
+#+end_src
+
+#+name: noweb-example1
+#+begin_src emacs-lisp :results silent :exports code
   (message "expanded1")
 #+end_src
 

Re: BUG typo in babel.org?

[Achim Gratz]

Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:
> as I'm still exploring org-mode and the way to write tests for,
> please have a look IIUC,

In any case you should check if that isn't done on purpose to test for the
reaction of Org to missing code references.  There are "negative" tests that are
expected to fail.


Regards,
Achim.

Re: BUG typo in babel.org?

[Andreas Röhler]

Am 26.02.2013 12:19, schrieb Achim Gratz:
> Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:
>> as I'm still exploring org-mode and the way to write tests for,
>> please have a look IIUC,
>
> In any case you should check if that isn't done on purpose to test for the
> reaction of Org to missing code references.  There are "negative" tests that are
> expected to fail.
>
>
> Regards,
> Achim.
>
>
>

Being well aware mistakes are possible. Erorr message was

Debugger entered--Lisp error: (void-variable <<noweb-example1>>)
   (progn <<noweb-example1>>)
   eval((progn <<noweb-example1>>))
   ((lambda (result) (if (member "none" #1=(cdr (assoc :result-params params))) nil (if (or (member "scalar" #1#) (member "verbatim" #1#) (member "html" #1#) (member "code" 
#1#) (member "pp" #1#) (and (member "output" #1#) (not (member "table" #1#)))) (let ((print-level nil) (print-length nil)) (if (or (member "scalar" ...) (member "verbatim" 
...)) (format "%S" result) (format "%s" result))) (org-babel-reassemble-table result (org-babel-pick-name (cdr (assoc :colname-names params)) (cdr (assoc :colnames 
params))) (org-babel-pick-name (cdr (assoc :rowname-names params)) (cdr (assoc :rownames params))))))) (eval (read (format (if (member "output" (cdr (assoc :result-params 
params))) "(with-output-to-string %s)" "(progn %s)") (org-babel-expand-body:emacs-lisp body params)))))
   (progn ((lambda (result) (if (member "none" #1=(cdr (assoc :result-params params))) nil (if (or (member "scalar" #1#) (member "verbatim" #1#) (member "html" #1#) (member 
"code" #1#) (member "pp" #1#) (and (member "output" #1#) (not ...))) (let ((print-level nil) (print-length nil)) (if (or ... ...) (format "%S" result) (format "%s" 
result))) (org-babel-reassemble-table result (org-babel-pick-name (cdr ...) (cdr ...)) (org-babel-pick-name (cdr ...) (cdr ...)))))) (eval (read (format (if (member 
"output" (cdr ...)) "(with-output-to-string %s)" "(progn %s)") (org-babel-expand-body:emacs-lisp body params))))))
   (unwind-protect (progn ((lambda (result) (if (member "none" #1=(cdr (assoc :result-params params))) nil (if (or (member "scalar" #1#) (member "verbatim" #1#) (member 
"html" #1#) (member "code" #1#) (member "pp" #1#) (and ... ...)) (let (... ...) (if ... ... ...)) (org-babel-reassemble-table result (org-babel-pick-name ... ...) 
(org-babel-pick-name ... ...))))) (eval (read (format (if (member "output" ...) "(with-output-to-string %s)" "(progn %s)") (org-babel-expand-body:emacs-lisp body 
params)))))) (set-window-configuration wconfig))
   (let ((wconfig (current-window-configuration))) (unwind-protect (progn ((lambda (result) (if (member "none" #1=(cdr ...)) nil (if (or ... ... ... ... ... ...) (let ... 
...) (org-babel-reassemble-table result ... ...)))) (eval (read (format (if ... "(with-output-to-string %s)" "(progn %s)") (org-babel-expand-body:emacs-lisp body 
params)))))) (set-window-configuration wconfig)))
   org-babel-execute:emacs-lisp(";; noweb-no-start\n  <<noweb-example1>>" ((:comments . #1="") (:shebang . #1#) (:cache . "no") (:padline . #1#) (:noweb . "no") (:tangle . 
"no") (:exports . "code") (:results . "silent") (:session . "none") (:padnewline . "yes") (:hlines . "yes") (:colnames . "no") (:result-type . value) (:result-params 
"silent") (:rowname-names) (:colname-names)))
   org-babel-execute-src-block(nil ("emacs-lisp" ";; noweb-no-start\n  <<noweb-example1>>" ((:comments . #1="") (:shebang . #1#) (:cache . "no") (:padline . #1#) (:noweb . 
"no") (:tangle . "no") (:exports . "code") (:results . "silent") (:session . "none") (:padnewline . "yes") (:hlines . "yes") (:colnames . "no") (:result-type . value) 
(:result-params "silent") (:rowname-names) (:colname-names)) "" nil 0))
   org-babel-execute-src-block-maybe()
   org-babel-execute-maybe()
   org-babel-execute-safely-maybe()
   run-hook-with-args-until-success(org-babel-execute-safely-maybe)
   (cond ((or (and (boundp (quote org-clock-overlays)) org-clock-overlays) org-occur-highlights org-latex-fragment-image-overlays) (and (boundp (quote org-clock-overlays)) 
(org-clock-remove-overlays)) (org-remove-occur-highlights) (org-remove-latex-fragment-image-overlays) (message "Temporary highlights/overlays removed from current buffer")) 
((and (local-variable-p (quote org-finish-function) (current-buffer)) (fboundp org-finish-function)) (funcall org-finish-function)) ((run-hook-with-args-until-success 
(quote org-ctrl-c-ctrl-c-hook))) (t (let* ((context (org-element-context)) (type (org-element-type context))) (if (save-excursion (beginning-of-line) (looking-at "[ 	]*$")) 
(or (run-hook-with-args-until-success (quote org-ctrl-c-ctrl-c-final-hook)) (user-error "C-c C-c can do nothing useful at this location")) (if (eq type (quote paragraph)) 
(progn (let (...) (if ... ...)))) (cond ((eql type (quote clock)) (org-clock-update-time-maybe)) ((eql type (quote dynamic-block)) (save-excursion (goto-char ...) 
(org-update-dblock))) ((eql type (quote footnote-definition)) (goto-char (org-element-property :post-affiliated context)) (call-interactively (quote org-footnote-action))) 
((eql type (quote footnote-reference)) (call-interactively (quote org-footnote-action))) ((memql type (quote ...)) (save-excursion (goto-char ...) (call-interactively 
...))) ((eql type (quote item)) (let* (... ... ... ... ... ...) (org-list-set-checkbox ... struct ...) (org-list-struct-fix-ind struct parents 2) 
(org-list-struct-fix-item-end struct) (org-list-struct-fix-bul struct prevs) (org-list-struct-fix-ind struct parents) (let ... ... ...))) ((eql type (quote keyword)) (let 
(... ...) (if ... ...) (let ... ... --rtn)) (message "Local setup has been refreshed")) ((eql type (quote plain-list)) (let* (... ... ... ... ...) (cond ... ...) 
(org-list-write-struct struct ... old-struct) (org-update-checkbox-count-maybe) (save-excursion ... ...))) ((memql type (quote ...)) (call-interactively (quote 
org-property-action))) ((memql type (quote ...)) (call-interactively (quote org-update-radio-target-regexp))) ((eql type (quote statistics-cookie)) (call-interactively 
(quote org-update-statistics-cookies))) ((memql type (quote ...)) (if (eq ... ...) (message "Use C-c ' to edit table.el tables") (let ... ...))) ((eql type (quote 
timestamp)) (org-timestamp-change 0 (quote day))) (t (or (run-hook-with-args-until-success ...) (user-error "C-c C-c can do nothing useful at this location"))))))))
   org-ctrl-c-ctrl-c(nil)
   call-interactively(org-ctrl-c-ctrl-c nil nil)
   command-execute(org-ctrl-c-ctrl-c)

Re: BUG typo in babel.org?

[Achim Gratz]

Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:
> Being well aware mistakes are possible.

That org file is used for some tests in test-ob-exp and not intended for you to
do manual evaluations in.  And from the test setup in ob-exp/noweb-on-export it
appears that the missing noweb-example1 is intended (as well as the double
definitions that lead to double expansions).  If you change something in that
file you also need to change the test definitions and vice versa.


Regards,
Achim.

Re: BUG typo in babel.org?

[Bastien]

Hi Achim,

Achim Gratz <Stromeko@NexGo.DE> writes:

>> Being well aware mistakes are possible.
>
> That org file is used for some tests in test-ob-exp and not intended for you to
> do manual evaluations in.  And from the test setup in ob-exp/noweb-on-export it
> appears that the missing noweb-example1 is intended (as well as the double
> definitions that lead to double expansions).  If you change something in that
> file you also need to change the test definitions and vice versa.

Thanks for the explanations, but closed then.

-- 
 Bastien