From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Timestamps: Handle sub-10-min ranges when updating timestamps Date: Thu, 08 Aug 2013 10:22:58 +0200 Message-ID: <87wqnwa8wt.fsf@gmail.com> References: <1375321732-26199-1-git-send-email-trevor.m.murphy@gmail.com> <87wqnxa9kj.fsf@gmail.com> <877gfwvgll.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7LUk-0001nS-I8 for emacs-orgmode@gnu.org; Thu, 08 Aug 2013 04:23:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7LUb-0006Sg-Mv for emacs-orgmode@gnu.org; Thu, 08 Aug 2013 04:22:54 -0400 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:49280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7LUb-0006SF-Gx for emacs-orgmode@gnu.org; Thu, 08 Aug 2013 04:22:45 -0400 Received: by mail-wi0-f182.google.com with SMTP id hi8so292114wib.9 for ; Thu, 08 Aug 2013 01:22:44 -0700 (PDT) Received: from selenimh ([91.224.148.150]) by mx.google.com with ESMTPSA id a8sm16315853wie.6.2013.08.08.01.22.43 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 08 Aug 2013 01:22:44 -0700 (PDT) In-Reply-To: <877gfwvgll.fsf@gmail.com> (Trevor Murphy's message of "Wed, 07 Aug 2013 23:31:18 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Trevor Murphy writes: > Schedule an event for today with a five-minute duration. E.g: > > * TODO test out bug in `org-schedule' > SCHEDULED: <2013-08-07 Wed 17:00-17:05> > > Then hit C-c C-s (or however you have `org-schedule' bound). With the > default setup, you'd expect to see the following prompt in the > minibuffer: > > Date+time [2013-08-07]: 17:00+0:05 > > however what you'll get instead is: > > Date+time [2013-08-07]: 17:00+0:5 > > The latter is not a valid time spec. If you simply accept it, then at > least on my install org reschedules the event to: > > SCHEDULED: <2013-08-07 Wed-17:00> > > Which is not what I intended. I'll add that you can get the same buggy > behavior from any command that calls `org-time-stamp' on an > already-timestamped event with <10 minute duration. OK. Thank you for the explanation. > I tested that and it felt noticeably slower when I called > `org-reschedule'. The extra `if' and `concat' did not feel slower. I > didn't do explicit timings because of the subjective feel (also because > I'm not really sure how to do those tests yet). That being said, I > agree with you. I doubt the difference between the two is noticeable. Something else happened when calling `org-reschedule'. > If you prefer, I'll resubmit the patch without the if => when and using > the format string. Please do. I'll apply it then. Regards, -- Nicolas Goaziou