From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: bug#22399: org-mode fontification Date: Tue, 19 Jan 2016 10:33:12 -0500 Message-ID: <87wpr5zirr.fsf@kyleam.com> References: <87oacjng36.fsf@russet.org.uk> <87ziw36khb.fsf@gmx.us> <87a8o2zrtm.fsf@russet.org.uk> <87bn8i7mha.fsf@gmx.us> <87d1syvgc7.fsf@kyleam.com> <8737tu13la.fsf__5430.1016768024$1453185240$gmane$org@kyleam.com> <87d1sy54vt.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLYHa-00081d-29 for emacs-orgmode@gnu.org; Tue, 19 Jan 2016 10:33:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLYHW-0002Ak-36 for emacs-orgmode@gnu.org; Tue, 19 Jan 2016 10:33:22 -0500 Received: from pb-smtp0.int.icgroup.com ([208.72.237.35]:56813 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLYHV-0002AZ-Vn for emacs-orgmode@gnu.org; Tue, 19 Jan 2016 10:33:18 -0500 In-Reply-To: <87d1sy54vt.fsf@gmx.us> (rasmus@gmx.us's message of "Tue, 19 Jan 2016 09:51:18 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Cc: 22399@debbugs.gnu.org Rasmus writes: > Kyle Meyer writes: [...] >> The first patch replaces the font-lock-ensure compatibility alias from >> 6711a21f1 with the one currently used in the Org repo (from commit >> e6883dd03). The new alias is limited to being called with no >> arguments, but, at the moment, no Org code calls font-lock-ensure with >> any arguments. > > I just have one concern, which is pretty theoretical. Isn=E2=80=99t it b= ad to > define the alias to be font-lock-ensure since this is an existing function > and people would have clear expectations of what they are calling? I > realize that there=E2=80=99s no Emacs-25 that will not have this function= (which > is why it=E2=80=99s very theoretical). I agree, but, like you, I'm not sure it will matter in practice. Again, this was the solution that was already in Org's repo at the time I backported Emacs's 6711a21f1. However, it's easy enough to switch to using an org-font-lock-ensure variant that avoids these issues, so I will do that (in an updated patch and on Org's maint). -- Kyle