From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Tasks don't repeat correctly if system-time-locale is set to
 certain languages
Date: Tue, 01 Nov 2016 01:04:21 +0100
Message-ID: <87wpgodq0q.fsf@nicolasgoaziou.fr>
References: <CALGAe2LJ=f20wSd7Pf30yG35nmCxO66-DANwC8butASSndv-wA@mail.gmail.com>
	<87a8dkfsou.fsf@nicolasgoaziou.fr>
	<CALGAe2Joi-cHAAvC4xYNtC41qA4ih1pNSYaa9oDtZMotZMKNvQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45158)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1c1MYu-00041G-Lf
	for emacs-orgmode@gnu.org; Mon, 31 Oct 2016 20:04:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1c1MYt-0005N0-TG
	for emacs-orgmode@gnu.org; Mon, 31 Oct 2016 20:04:20 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:55675)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1c1MYt-0005LZ-Mu
	for emacs-orgmode@gnu.org; Mon, 31 Oct 2016 20:04:19 -0400
In-Reply-To: <CALGAe2Joi-cHAAvC4xYNtC41qA4ih1pNSYaa9oDtZMotZMKNvQ@mail.gmail.com>
	(Bruce V. Chiarelli's message of "Mon, 31 Oct 2016 15:47:51 -0700")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: "Bruce V. Chiarelli" <mano155@gmail.com>
Cc: emacs-orgmode@gnu.org

"Bruce V. Chiarelli" <mano155@gmail.com> writes:

> org-todo calls org-auto-repeat-maybe, which sees the ".+" style
> repeater. It calls org-timestamp-change to move the timestamp up to
> today. Point is left at the closing bracket. So far, so good.
>
> org-timestamp-change sets origin-cat to 'after and origin to (point).
> It then changes the timestamp to today as advertized.
>
> Now these lines get evaluated
>
>     (goto-char (cond
>             ;; `day' category ends before `hour' if any, or at
>             ;; the end of the day name.
>             ((eq origin-cat 'day)
>              (min (or (match-beginning 7) (- (match-end 5) 2)) origin))
>             ((eq origin-cat 'hour) (min (match-end 7) origin))
>             ((eq origin-cat 'minute) (min (1- (match-end 8)) origin))
>             ((integerp origin-cat) (min (1- (match-end 0)) origin))
>             ;; `year' and `month' have both fixed size: point
>             ;; couldn't have moved into another part.
>             (t origin))))
>
> The since origin-cat is 'after, matching nothing else, we get
> (goto-char origin).
>
> This seems to be where the problem lies. When "<2016-10-29 szo .+1>"
> becomes "<2016-10-31 h .+1>" (today), origin is now two characters
> ahead of where it should be, now on the next line in fact.

I see. Thank you for the analysis.

Does adding the following branch in the `cond' above, before the
catch-all one, solves the issue?

  ((eq origin-cat 'after) (match-end 0))


Regards,