From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aPyqHekF5F50PAAA0tVLHw (envelope-from ) for ; Fri, 12 Jun 2020 22:47:05 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gMdiGekF5F74WAAAbx9fmQ (envelope-from ) for ; Fri, 12 Jun 2020 22:47:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E542D9403EE for ; Fri, 12 Jun 2020 22:47:04 +0000 (UTC) Received: from localhost ([::1]:55896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjsRy-0000j7-LO for larch@yhetil.org; Fri, 12 Jun 2020 18:47:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjsRd-0000ih-FD for emacs-orgmode@gnu.org; Fri, 12 Jun 2020 18:46:41 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:47485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjsRb-00028Y-7U for emacs-orgmode@gnu.org; Fri, 12 Jun 2020 18:46:41 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 429EEFF802; Fri, 12 Jun 2020 22:46:34 +0000 (UTC) From: Nicolas Goaziou To: Mario Frasca Subject: Re: [PATCH] allow for multiline headers In-Reply-To: (Mario Frasca's message of "Fri, 12 Jun 2020 12:14:17 -0500") Date: Sat, 13 Jun 2020 00:44:14 +0200 Message-ID: <87wo4bhpkx.fsf@nicolasgoaziou.fr> References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Mail-Followup-To: Mario Frasca , emacs-orgmode@gnu.org MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.199; envelope-from=mail@nicolasgoaziou.fr; helo=relay9-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/12 18:46:35 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: lVIX0XgovvqR Hello, Mario Frasca writes: > (org-table-to-lisp): simplify code, changing a `while' to a > `cl-loop', remove leading `hline' symbols from result, edit > documentation to reflect change. Please don't. Even if it has its uses, cl-loop is a complicated non-Lispy beast, and introducing it somewhere is seldom a simplification. If you think cl-loop is more efficient in this function, please provide benchmarks. But I really hope cl-loop (or cl-do, for that matter) is not going to sprout everywhere. Also, the first hline is used to determine where to end the header. A table starting with a hline has no header. Therefore, I suggest to avoid removing hlines at the beginning of a table, we would lose information. Regards, -- Nicolas Goaziou