From: Jens Lechtenboerger <lechten@wi.uni-muenster.de>
To: Kyle Meyer <kyle@kyleam.com>
Cc: org-mode-email <emacs-orgmode@gnu.org>, TEC <tecosaur@gmail.com>
Subject: Re: [PATCH] tweaks to ox-html style
Date: Fri, 12 Feb 2021 17:57:44 +0100 [thread overview]
Message-ID: <87wnvd2ph3.fsf@wi.uni-muenster.de> (raw)
In-Reply-To: <878s7t95fu.fsf@kyleam.com> (Kyle Meyer's message of "Fri, 12 Feb 2021 01:16:21 -0500")
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
On 2021-02-12, Kyle Meyer wrote:
> TEC writes:
>
>> Hi All,
>>
>> This is just some tweaks to the styling in ox-html that I think may
>> appeal (and prevent ridiculously long lines on non-small displays, which
>> are an issue for legibility).
>>
>> I also took the opportunity to remove the (obsolete) CDATA strings and
>> make the CSS more consistently formatted. If you don't want this to
>> get its own commit, please just squash it.
>>
>> Style changes:
>> - Restrict max content width, and centre
>> - tweak styling of source code blocks
>
> I'm sure there are plenty of opinionated ox-html users on the list. Is
> anyone willing to provide feedback on this series? Please don't assume
> you need commit access to provide reviews.
Hi there,
I do not know why the CDATA lines exist. I don’t see a reason to
keep them (patch 0001), but that might be a lack of understanding on
my part.
Patch 0003 is about whitespace fixes.
Patches 0002, 0004, 0005 change defconst styling. I don’t have a
strong opinion here. However, if they are changed now, what about
turning them into defcustoms? Then each of us would be entitled to
their own opinion ;)
The docstring for org-html-head-include-default-style says that
org-html-style-default (a defconst proposed to be changed here)
should not be changed. Why not?
Best wishes
Jens
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5290 bytes --]
next prev parent reply other threads:[~2021-02-12 16:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 10:46 [PATCH] TEC
2021-01-20 11:00 ` [PATCH] tweaks to ox-html style TEC
2021-02-12 6:16 ` Kyle Meyer
2021-02-12 16:57 ` Jens Lechtenboerger [this message]
2021-02-12 17:08 ` Jens Lechtenboerger
2021-02-12 18:22 ` Timothy
2021-02-13 14:43 ` Jens Lechtenboerger
2021-02-12 18:16 ` Timothy
2021-02-12 21:46 ` Tim Cross
2021-02-13 9:28 ` Eric S Fraga
2021-02-13 13:32 ` Christian Moe
2021-02-14 4:36 ` Timothy
2021-04-28 3:38 ` [PATCH] Bastien
2021-04-28 3:53 ` [PATCH] Timothy
2021-04-28 6:36 ` [PATCH] Bastien
2021-04-28 6:33 ` [PATCH] Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnvd2ph3.fsf@wi.uni-muenster.de \
--to=lechten@wi.uni-muenster.de \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
--cc=tecosaur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).