From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aWYFDpjaGGGlTgEAgWs5BA (envelope-from ) for ; Sun, 15 Aug 2021 11:12:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iOwOCZjaGGGTHwAAbx9fmQ (envelope-from ) for ; Sun, 15 Aug 2021 09:12:56 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7D2D72044 for ; Sun, 15 Aug 2021 11:12:55 +0200 (CEST) Received: from localhost ([::1]:35326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFCCL-0003N8-7b for larch@yhetil.org; Sun, 15 Aug 2021 05:12:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFCBp-0003Ml-RN for emacs-orgmode@gnu.org; Sun, 15 Aug 2021 05:12:21 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:45788) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mFCBo-0006Oe-9e for emacs-orgmode@gnu.org; Sun, 15 Aug 2021 05:12:21 -0400 Received: by mail-wr1-x430.google.com with SMTP id v4so12153253wro.12 for ; Sun, 15 Aug 2021 02:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=b/W+LForyO0kt0CT4Nq18ahjL3o7P5Rpj7yoqhoV5Tc=; b=Vj0pMVtaI0gwMHgL4JZR0+gryGlKgWQ3MLrj9BG+OcnMDQ+3f1zj/nuFriiMoKI8d1 2Dkp05TOtije6ilhpU8xtdtHp0RGG+sTun/j4ZJrEpBUNaVPt2pcbrwGTnKy4KM5BBqJ fqNvC6SYWC1YFQ281+fPsxfmOgeih6BecRyNNN36sN6Ky1fIgqk+F7bFXv+9dkxwVnaN Sf7OyJV1cLYFeEJCsUnV6WboAbODSl/H1wWnCxtSqHsocJmjJu0EjYnCLCjiuYs5AE7H vCikJHMKaBoruz6tzaPgn8BLc3E8HS8BrZoJvPEiy1xFt5NT82JPtv9PUJX2VVRxKEUE BfUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=b/W+LForyO0kt0CT4Nq18ahjL3o7P5Rpj7yoqhoV5Tc=; b=Frkr3B8YIu6DghjJgB2cLNWqi0sFdIzYdoPmr5uipWmdWbze/Hoe5pYiAleo8OFhy5 1yaNo/8p2/2vIPlnS0RrUnND4IA4Lfi/xXqO3kse+FKJ4kfSOyw3fYorIIgiHIx1W5VO gCtQBTSM/g2sq3ot3d4B34Otovymbo4CF07itaaywcnZNz5XHVEvaNVj3c5duJRShkxG Tc9n/JItciqRHWAwknCxJP1vXPwSw8f3ymPoB1Sl4Lr30Og0XVed1W2Y9CZun9yopp7r deLMN11akzU4VceAKq+t3PSf6Q/bKVkyNC9IwP+GeDYZh8MPG1+2Sp1+qlTK0QWbCvys NPgQ== X-Gm-Message-State: AOAM530DUhk9yOuhgWEcN1S3vt/EvRr9o6yRySEGQf5GhIkH+FH9zkN6 J4PIwAjC3KXGM3WdhJyACYE= X-Google-Smtp-Source: ABdhPJy71QOF6dwVvUD3GQDDAVzKaUibXz6ryYUVQqhmmeCv3CWSgLzAky3dxBfo6wNHqyzX0NFMrw== X-Received: by 2002:a05:6000:18a4:: with SMTP id b4mr12734063wri.162.1629018738254; Sun, 15 Aug 2021 02:12:18 -0700 (PDT) Received: from aspire-5942 (p200300d867252100d5381445ac32660d.dip0.t-ipconnect.de. [2003:d8:6725:2100:d538:1445:ac32:660d]) by smtp.gmail.com with ESMTPSA id n29sm6536489wms.2.2021.08.15.02.12.17 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 15 Aug 2021 02:12:17 -0700 (PDT) From: Marco Wahl To: Maxim Nikulin , Kyle Meyer Subject: Re: org-attach-sync uses directory-empty-p (new in Emacs 28) References: <87pmun8t2o.fsf@kyleam.com> <87lf593tv0.fsf@gmail.com> <9dd6d3bf-46cc-31a2-aead-3af7d53e741c@gmail.com> <87lf57y92w.fsf@gmail.com> Date: Sun, 15 Aug 2021 11:11:55 +0200 In-Reply-To: (Maxim Nikulin's message of "Thu, 12 Aug 2021 18:57:35 +0700") Message-ID: <87wnonjcmc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=marcowahlsoft@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1629018775; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=b/W+LForyO0kt0CT4Nq18ahjL3o7P5Rpj7yoqhoV5Tc=; b=kTttGdUUd4LI6yDkvPC2bJopf+oYlfQVwuW4eS4MM2uT5mfKk4XB14sSKBRCW2KjSCEEK6 gOjWY+GboWtPdGx/3JysfUAI4XMr4gdzsS09SH3XQOaHDCvvfKx8UDi1q9jV7iU6L4yM5z YDUT9mRmezOicM2lO9WYq2MQnjq4Z3HMAf49JOPdmL3i2Yvl06Dn6wi1dOqXrSiXIQxEMe ocgCwhZH3Y6cSEHPAQGAPj7DF0H7Wb5kdKlIfS5s843kdHrHlvlXNPqdneTOtVKG76iOvq KmDlATuiYYAAdI8TzIMMd3ICmZinYsZbElIwN/0jsR+XIwnY28VyETQf6j6fwA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1629018775; a=rsa-sha256; cv=none; b=Aok7xB/nVohAtlMWAd3bqJ8S02hz4wkdZAp4o6KuXCVNpw4gYYFiKsnQs7ZO4MlSeHwxX5 Qh5GOMvtpfLAgfscRYnI//yPpo8Fwv555r6/ACQlpOn7Q1G6vVvYWG/Ho/7DlqluzxFPJi Bq9Wpdn9m5bcZjHDjr8eD4CiJA64Y89z6Wq9SyDF/HBtd+prMcDK7KjZVED/9rmjeKNrG/ fZ8tUxCaKLe0Xrreso8cQHcPVdt+jjyNjATvigCzNmaKRU5E2VukyAn7ImUrBsyvqAl0MU 8IGpL1sMLxk3mgHABhYOI4sB1O/j/Y4nBN8S/Bpb+Upg+60q5S67qXV43NdsUw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Vj0pMVta; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.11 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Vj0pMVta; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 7D2D72044 X-Spam-Score: -3.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: OstaLNKUrP2t Maxim Nikulin writes: >>> Compiling single /home/ubuntu/org-mode/lisp/org-compat.el... >>> >>> In end of data: >>> org-compat.el:1255:1:Warning: the function =E2=80=98directory-empty-p= =E2=80=99 is not >>> known to >>> be defined. > I have never fought with this kind of problem. After looking at the > other constructs in the org-compat.el file, I have tried > > (if (fboundp 'directory-empty-p) > (defalias 'org-directory-empty-p #'directory-empty-p) > (defun org-directory-empty-p (dir) > ; ... > > I have no idea if there are any drawbacks of such approach, I can only > say that such form suppresses the warning. Thanks Maxim and Kyle! The latter suggestion landed in master a few minutes ago. Have a great day! -- Marco