From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OCWoJ90SUGG0KwEAgWs5BA (envelope-from ) for ; Sun, 26 Sep 2021 08:27:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id iN4bI90SUGGjKwAAbx9fmQ (envelope-from ) for ; Sun, 26 Sep 2021 06:27:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F2B5928873 for ; Sun, 26 Sep 2021 08:27:40 +0200 (CEST) Received: from localhost ([::1]:48648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUNdT-0006Yg-OA for larch@yhetil.org; Sun, 26 Sep 2021 02:27:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUNcM-0006Vk-Qp for emacs-orgmode@gnu.org; Sun, 26 Sep 2021 02:26:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36964) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUNcM-0004Ef-Ff; Sun, 26 Sep 2021 02:26:30 -0400 Received: from [2a01:e34:ec2b:7150:9b07:b8c3:15f:4214] (port=58582 helo=hal) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUNcM-0007D6-9C; Sun, 26 Sep 2021 02:26:30 -0400 Received: by hal (Postfix, from userid 1000) id 5D8071E041B; Sun, 26 Sep 2021 08:26:29 +0200 (CEST) From: Bastien To: Ihor Radchenko Subject: Re: [PATCH] Re: Bug: Duplicate logbook entry for repeated tasks [9.4.6 (9.4.6-gab9f2a @ /home/gustavo/.emacs.d/elpa/org-9.4.6/)] In-Reply-To: <87a6muwa93.fsf@localhost> (Ihor Radchenko's message of "Sat, 10 Jul 2021 21:48:08 +0800") Organization: GNU References: <877diwbm6a.fsf@gmail.com> <87a6muwa93.fsf@localhost> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sun, 26 Sep 2021 08:26:29 +0200 Message-ID: <87wnn3g8dm.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Gustavo Barros , Bhavin Gandhi Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632637661; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=9Ksts3PmwKzOuKlbdqTOqyurQgCd4imh8U5RM9pQmBQ=; b=KLsr082wq+ACenwhrD+zLRE5k6W8p4iTPLr6ve8H6/oIt8iXc46sAy/LR3GXk9x0Ixjrge j9r293PsmkyIxJqADtGPYnPm7D69V8VBzaLRXIWz2AE9wIa7tj7mpEqtgu+DlJu8ZHpWPs OdSOcRR0VXJek0mgNFr8w0RWUISkpi/9KlJTzDm/FQlha/HJP62HrBGeiOD8GbVcCkM2m+ oBwhaRBuwC0am9DSZay88UoiSFAHp/duXpvzlqRJK45uAupfgq919Zyxqp7Ib10KnyXZwu sc9VcsNqlYu3PX0cmmTCBV1mJF5hkus06QYV/ZjCypnWfJjXrWZ8o0cyXTHQbg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632637661; a=rsa-sha256; cv=none; b=BmaTJ+Xg6Q2v9rkSJnNk0xJos+u07mVCd9v3+owl0a4fvA/gCZ1Glg2cNH0fBEa0n+36Pk MJcnKWgpp0eQXgsMoVBATeEE5MoDFoS2KdCYKJgS5hBgkjXYfM/1TY+ZUC6bOq+zK2p7Xl py2SKZhNFFA5kGNPh4VAaJZCzSoefcZ0Sk+xIjKUgATsVLKH0G9uABnOz3cuhyFl0Qw9Y4 GnaCJQ11R2HVOe0DWisCal7nFCpA+c+kFyev92kyyqiGj6chK+wB4Dw6EUiYFioKE3NsnG HWeM7i6d+ZBo+OAWSyxjUcKgTkWahIGc579QuJDHj0vYEhcmjaKljd/1nDBgtg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.39 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: F2B5928873 X-Spam-Score: -1.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: MxGStK1AyYZg Hi Ihor, Ihor Radchenko writes: > Bhavin Gandhi writes: > >> I was able to reproduce this, and here are my findings as well as a >> reproducible configuration with only a few settings. > > The breakage was introduced in commit c67037: > > [c670379adfbdc4883d3cfa230289fd2829993265] Fix `org-agenda-todo' undo behavior when logging (not adding note) > > The fix is attached. Applied in the bugfix branch, thanks. This area is quite fragile, so please let's test this heavily. Thanks! -- Bastien