From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oGkwNHMwv2ORCwEAbAwnHQ (envelope-from ) for ; Wed, 11 Jan 2023 22:56:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yAqZNHMwv2OEtQAAauVa8A (envelope-from ) for ; Wed, 11 Jan 2023 22:56:03 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9593B253B0 for ; Wed, 11 Jan 2023 22:56:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFj3r-00056H-PA; Wed, 11 Jan 2023 16:55:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFj3q-000565-Lq for emacs-orgmode@gnu.org; Wed, 11 Jan 2023 16:55:06 -0500 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFj3o-0003kB-W4 for emacs-orgmode@gnu.org; Wed, 11 Jan 2023 16:55:06 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pFj3l-0002cq-V4 for emacs-orgmode@gnu.org; Wed, 11 Jan 2023 22:55:01 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Leo Butler Subject: Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects Date: Wed, 11 Jan 2023 15:51:11 -0600 Message-ID: <87wn5sloz4.fsf@t14.reltub.ca> References: <87mt92elyy.fsf@t14.reltub.ca> <87mt9128sz.fsf@localhost> <87zgd1b4rn.fsf_-_@t14.reltub.ca> <8735asbtfe.fsf@localhost> <87pmdvamwf.fsf@t14.reltub.ca> <87bkpaguy3.fsf@localhost> <87leocuhpg.fsf@t14.reltub.ca> <87359esah2.fsf@localhost> <87cz8ifioa.fsf@localhost> <87sfh9vukl.fsf@localhost> <87fsd7wolt.fsf@t14.reltub.ca> <87r0wk29dz.fsf@localhost> <87358ywn5g.fsf@localhost> <87bknh5nva.fsf@localhost> <87358ovj53.fsf@t14.reltub.ca> <87a62vitpu.fsf@localhost> <87lemfqbwl.fsf@t14.reltub.ca> <87o7r6m8sf.fsf@t14.reltub.ca> <87fschfhke.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cancel-Lock: sha1:TEl+tFF+WRvHn9mSN16DQbSMvx0= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673474163; a=rsa-sha256; cv=none; b=SO9WOPDdwMl+m+pJpfIoBMVqLw6aWi3otKUI26y90W4TvZGBYlHpQ4py0zkNk14xXDzubq lOfCO4Hp80aemlhnw920031oN4rysCZ0HMSl096Ox7H+lyrB2N4mPqsf7wlX7CQE9+voSC +yTxS7x15VeJ/IAr0BSZcpKZ5IDi0yXRtE71sE6lxk7uZsE3A7XDbkKfLg3Vc30lIro4xv MTrKYh7Mw2B3wkovYEW+Aw4u8BWK2AZoFopFyR5D26eeE0i1nwAvdqB3Y6eNgNJs4ZYJTT 6oJAvjgjv/tPe94LkY0YSFGwKOontVZTZ1DpqwctACzZZ3O/1E987dW6we4Q2g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673474163; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2lu5Q4WiLIpUVDylSCL5RYDHq7xTgTKk0zTVs5QJVrU=; b=MpZVdHvRehzItM1Fmw/UtuZd9Gz7Q5azsMfUT9bCMYtfEj6bwgEajjev8/WQtQ3XpUb2IE EBMDoaG3vjQRmwJQikpfzkCn069NWyuhDa2R1p4Lfi8aZUyZrpjh70UNvZcE/OmqINZsgw Dp4bW9E9xXCwrS1ssLYDWIkeNCAYeTacgVUof4GRGe7P/vKeKi8fP3eb9LkIHzd9b5Mh+q xKC+Eiw0Ipqgq/rA2L0uV9hjYGerQ6QheXpcuwzN345GO0ocw8TCBuGfkKqwDGylqK6cR4 hs3VNWynbBFmITX8hFdC+OIM59MucVAWHfeVqgDBr/ZWZd6b8hGrSAZTkCisaw== X-Migadu-Spam-Score: -2.40 X-Spam-Score: -2.40 X-Migadu-Queue-Id: 9593B253B0 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: xV4vC9fK4szs On Wed, Jan 11 2023, Ihor Radchenko wrote: > Leo Butler writes: > >>>>>> Leo, could you please take a look? >>>>> >>>>> An earlier test is creating that *Org Babel Error Output* buffer. >>> >>> I will try to look into improving the tests so that we can trap the test(s) >>> that is(are) creating that error buffer. >> >> See the attachment. There are four test failures that are currently >> untrapped. I also see the `buffer-live-p' bug. > > It looks like `buffer-live-p' is not a bug, but rather the result of > backtrace being printed upon executing `kill-buffer' in unwind-protect > form from the test body: (1) test fails; (2) unwind-protect executes > kill-buffer; (3) backtrace is printed with "killed" buffer object. Yes, that seems reasonable. > > So, the test failure is real. > > https://orgmode.org/list/94980226-D29A-4969-8640-1143A1979164@bundesbrandschatzamt.de > might be related. Ihor, How do you want to treat the patch that was included? I think we should have something like that to catch errors like these. And the failing tests should be marked as known failures (that need to be fixed, obviously). I note that both failures 3 & 4 are related to org's built-in features. Leo