From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id kOIdEM9ZNmWEcgAAauVa8A:P1 (envelope-from ) for ; Mon, 23 Oct 2023 13:32:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kOIdEM9ZNmWEcgAAauVa8A (envelope-from ) for ; Mon, 23 Oct 2023 13:32:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AE9E96229F for ; Mon, 23 Oct 2023 13:32:30 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=IZK8zi+r; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698060751; a=rsa-sha256; cv=none; b=GLbM4ZZ/lONag64qkRzuAM2/9xADVrE5GT4d98S+ecRLzWM7Iw+YNcIlOGLx6+sZUrIgCU gfYzUFUBjDq1x/dvcO94su2EfD9NLYmFcBxOmancKhdd5jtY0FBwyXlacbwd66rBaNEbAx BV8MMuKgTPiixnebruSDSTuHGG/apu8o6IZ4Q9p8pba8uZtEXFAV+5BUN+0kiVB03OQ+B1 /P95WmoNocfrz3pSq5MoSNKgCji2EcOtPpf60o6ORvf3DCU9GinMCNLYD2qvo8xS6JRBAt eNPO0Uf6S2CYOhbDKyaNud3+1YcT4ydDYUFikwUYmBpRp4sE1T0IehOadUFS+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=IZK8zi+r; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698060751; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tqnY/YiKQreqzLRSzEPbaRdFgF4CzP44x84rL/X9Cns=; b=BUgQggR/lghV01KgVOoGnZbfIQ/1Tbx6rgQ0bwJ3Yc1VrYrm9yoYuSX89TM2mgoN2umptg K26B4YMm0csk56t56uS5j9xzFpqupQlHNpfxQMekWZ7xLbKo1SiFNO1PVvTcC3RfoKLhOC 8HjrlholngrwkNi8YkKnfRRddkwdmLVTumET5w7EbkW3k0w8w9PH3+VpCLIN/ZkpaxkUFC 0XjesV3AZDbeb1jmWgJwjmOBdoLFRLejj0aCDJC1WNnyOba0jR7LWBPUwIanabGraPEGWH Dg8JXN2bVfInbXTSl2lzX5+XtA2Qemvuwrqd5b9IvBcI1Ly+Dnm/c/n2H1fc3A== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qut9O-0007Ia-La; Mon, 23 Oct 2023 07:31:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qut9N-0007HO-0z for emacs-orgmode@gnu.org; Mon, 23 Oct 2023 07:31:13 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qut9K-0003Ss-1R for emacs-orgmode@gnu.org; Mon, 23 Oct 2023 07:31:12 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C69DC240027 for ; Mon, 23 Oct 2023 13:31:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1698060666; bh=Atal5qeBIuE2Kwbk06Pf+twxYdwY5JnrJQK+4MQ1D4k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=IZK8zi+rwxzrL8MVHs9XDb1K9bEJ6W7mgOmlqy81OlQA8B9F4qMyH2lMawGoijUCc K1H8ik/v+qijCGDeTxlpalb74bFkEGPDzPdJTLiRjifzZUYSrCwo+0NgCEO0pTxKh2 NHOwevUnYQ4+4Z8IwNvh8Chod19pZdFg3nM02fUGWUJ5fWcUsrL5wHZ9bLiLnd2jL0 kU3O8anvD2UJfHW48oElNPXPeRPyBntm9BSacQpN0xmoQNDDxtz6ZKG3ojGWt1l7yr qAKywhnRSjEL1OMZ8/ZFfRFRo6vnVkjX0RxtMlEjB3RGbpLB67rS+qTSoN17BDixdm h50ZqaPo6067g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SDY0p2Ypjz9rxP; Mon, 23 Oct 2023 13:31:06 +0200 (CEST) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [FR] Should we preserve point when calling `org-open-at-point' (C-c C-o) on a heading (was: [BUG] Point position with org-open-at-point on a heading [9.6.6 (release_9.6.6 @ /usr/local/share/emacs/29.1/lisp/org/)]) In-Reply-To: <877cof25vr.fsf@localhost> References: <87r0mp2srd.fsf@localhost> <877cof25vr.fsf@localhost> Date: Mon, 23 Oct 2023 11:32:49 +0000 Message-ID: <87wmvd8tge.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -4.83 X-Spam-Score: -4.83 X-Migadu-Queue-Id: AE9E96229F X-TUID: sbaswTI4kFKD Ihor Radchenko writes: >>>> Perhaps there's some reason why >>>> point is not preserved in this case. But for me at least, this is not >>>> what I'd expect, and I find it somewhat disrupting, especially when >>>> I'm working on a folded tree (defeats speed keys, etc.). >>> >>> I see no particular reason. >> >> Maybe the following is a false alarm. I hope `save-excursion' will not >> break the "RET to open all" option, `org-open-at-point' is called >> recursively this case. > > "Open all" is broken now. > > That said, your concern is valid - if we open internal link, it will be > expected the point jumps to that link rather than staying on the > heading. I believe that I now addressed all the concerns: 1. Point position is not preserved by default. 2. When a link being open moved point in current buffer, we do allow changing the position. 3. When multiple links are open, things should not be broken. 4. When multiple links are open and some of them (more than 1) also move point, we move point to the position defined by the last of such links. Fixed, on main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=098f08159 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at