From: Visuwesh <visuweshm@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add repeat-map for navigation commands
Date: Tue, 10 Sep 2024 10:41:35 +0530 [thread overview]
Message-ID: <87wmjk6qk8.fsf@gmail.com> (raw)
In-Reply-To: <8734m8rcoh.fsf@localhost> (Ihor Radchenko's message of "Mon, 09 Sep 2024 16:53:34 +0000")
[திங்கள் செப்டம்பர் 09, 2024] Ihor Radchenko wrote:
>> ... I've attached a patch which
>> adds a repeat-map to org-keys.el but this pointed out that org-mode
>> lacks a org-up-heading command so I've resorted to using
>> outline-up-heading.
>
> It is not the only one. But outline version should also work.
I just realised that we would need a few defalias-es if we are going to
have outline commands in the repeat-map to avoid overriding
outline-navigation-repeat-map when one uses outline-up-heading in
outline-minor-mode or outline-mode.
[திங்கள் செப்டம்பர் 09, 2024] Karthik Chikmagalur wrote:
>>> From 8b980efcd9497e395f4d82a1304267ae4426b00d Mon Sep 17 00:00:00 2001
>>> From: Visuwesh <visuweshm@gmail.com>
>>> Date: Mon, 9 Sep 2024 19:46:47 +0530
>>> Subject: [PATCH] Add repeat-mode keymap for navigation commands
>>>
>>> * org-keys.el (org-navigation-repeat-map): Add repeat-map to make
>>> navigation easier when repeat-mode is turned on.
>>
>> May you also add a news entry?
>> Ideally, we should also document this in the manual.
I will add this along with the above in the next patch.
> Do you think it makes sense to add repeat-maps for other next/previous
> commands in Org, such as org-next-link and org-previous-link? I've been
> using this for a while (they don't use defvar-keymap as I wrote them a
> while ago):
>
> (defvar org-link-navigation-repeat-map
> (let ((map (make-sparse-keymap)))
> (define-key map (kbd "n") #'org-next-link)
> (define-key map (kbd "p") #'org-previous-link)
> (define-key map (kbd "v") #'org-link-preview) ;toggle preview for link at point
> map))
>
> (map-keymap
> (lambda (_ cmd)
> (put cmd 'repeat-map 'org-link-navigation-repeat-map))
> org-link-navigation-repeat-map)
>
> (defvar org-block-navigation-repeat-map
> (let ((map (make-sparse-keymap)))
> (define-key map (kbd "f") #'org-next-block)
> (define-key map (kbd "b") #'org-previous-block)
> map))
>
> (put 'org-next-block 'repeat-map 'org-block-navigation-repeat-map)
> (put 'org-previous-block 'repeat-map 'org-block-navigation-repeat-map)
I also have a repeat-map for org-todo since I have
org-support-shift-select to t which makes changing the TODO when in the
body text quite inconvenient.
BTW, should we add C-n and friends to org-navigation-repeat-map or just
have n, p, etc.? I personally find C-n in the repeat-map disruptive
since I usually want to move the cursor after jumping to a specific
heading, in which case C-n not being next-line is annoying.
next prev parent reply other threads:[~2024-09-10 5:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 14:21 [PATCH] Add repeat-map for navigation commands Visuwesh
2024-09-09 16:53 ` Ihor Radchenko
2024-09-10 1:36 ` Karthik Chikmagalur
2024-09-15 12:54 ` Ihor Radchenko
2024-09-10 5:11 ` Visuwesh [this message]
2024-09-15 13:08 ` Ihor Radchenko
2024-09-16 12:29 ` Visuwesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmjk6qk8.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).