From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: [PATCH] Fix uncaught error when trying to open a link at point
Date: Wed, 13 Feb 2013 16:25:39 +0100
Message-ID: <87vc9wutfw.fsf@bzg.ath.cx>
References: <87ehjmvxk7.fsf@konixwork.incubateur.ens-lyon.fr>
	<87bodpdskd.fsf@bzg.ath.cx>
	<87wqvtrxcp.fsf@konixwork.incubateur.ens-lyon.fr>
	<87pq1lrssp.fsf@konixwork.incubateur.ens-lyon.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:58268)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1U5eDY-0005dv-Ci
	for emacs-orgmode@gnu.org; Wed, 13 Feb 2013 10:25:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1U5eDS-0000di-Lg
	for emacs-orgmode@gnu.org; Wed, 13 Feb 2013 10:25:52 -0500
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:51851)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1U5eDS-0000dd-98
	for emacs-orgmode@gnu.org; Wed, 13 Feb 2013 10:25:46 -0500
Received: by mail-wg0-f42.google.com with SMTP id 12so4309916wgh.5
	for <emacs-orgmode@gnu.org>; Wed, 13 Feb 2013 07:25:45 -0800 (PST)
In-Reply-To: <87pq1lrssp.fsf@konixwork.incubateur.ens-lyon.fr> (Samuel Loury's
	message of "Fri, 04 Jan 2013 14:17:42 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Samuel Loury <konubinix@gmail.com>
Cc: OrgMode ML <emacs-orgmode@gnu.org>

Hi Samuel,

Samuel Loury <konubinix@gmail.com> writes:

> It adjusts org-open-at-point to have plain links handled the same way
> bracket links are. It allows plain links to be followed if the cursor is
> before the link while still on the same line.

I applied a slightly modified version of your patch, condensing
comments.  See the change here:

http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=9964d8

> I also got rid of dangling parenthesis as suggested by
> Nicolas. Personally, I think it is easier to read with dangling
> parens. Could you explain what is wrong with them?

It's easy to allow oneself to have one or two dangling parentheses
when it clarifies code reading, but when you start using dangling
parentheses, it's hard to know where to stop... in any case, more
of a matter of convention + taste.

Thanks,

-- 
 Bastien