emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: Samuel Loury <konubinix@gmail.com>
Cc: OrgMode ML <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix uncaught error when trying to open a link at point
Date: Wed, 13 Feb 2013 16:25:39 +0100	[thread overview]
Message-ID: <87vc9wutfw.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87pq1lrssp.fsf@konixwork.incubateur.ens-lyon.fr> (Samuel Loury's message of "Fri, 04 Jan 2013 14:17:42 +0100")

Hi Samuel,

Samuel Loury <konubinix@gmail.com> writes:

> It adjusts org-open-at-point to have plain links handled the same way
> bracket links are. It allows plain links to be followed if the cursor is
> before the link while still on the same line.

I applied a slightly modified version of your patch, condensing
comments.  See the change here:

http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=9964d8

> I also got rid of dangling parenthesis as suggested by
> Nicolas. Personally, I think it is easier to read with dangling
> parens. Could you explain what is wrong with them?

It's easy to allow oneself to have one or two dangling parentheses
when it clarifies code reading, but when you start using dangling
parentheses, it's hard to know where to stop... in any case, more
of a matter of convention + taste.

Thanks,

-- 
 Bastien

  parent reply	other threads:[~2013-02-13 15:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-22  8:42 [PATCH] Fix uncaught error when trying to open a link at point Samuel Loury
2012-11-28 12:53 ` Nicolas Goaziou
2012-12-20  8:41 ` Bastien
2013-01-04 11:39   ` Samuel Loury
2013-01-04 13:17     ` Samuel Loury
2013-01-04 16:18       ` Bastien
2013-01-14 10:35         ` Samuel Loury
2013-02-13 15:25       ` Bastien [this message]
2013-02-13 16:39         ` Samuel Loury
2013-02-13 16:49           ` Bastien
2013-03-16 19:22             ` Samuel Loury
2013-03-16 19:32               ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vc9wutfw.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=konubinix@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).