From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound' Date: Tue, 30 Jul 2013 12:46:50 +0200 Message-ID: <87vc3sjpet.fsf__26121.076118625$1375181335$gmane$org@bzg.ath.cx> References: <87a9l67q2b.fsf@tue.nl> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V47TN-0006NW-AT for emacs-orgmode@gnu.org; Tue, 30 Jul 2013 06:48:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V47TH-0004On-9e for emacs-orgmode@gnu.org; Tue, 30 Jul 2013 06:48:09 -0400 Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Message-ID: In-Reply-To: <87a9l67q2b.fsf@tue.nl> (Oleh's message of "Sun, 28 Jul 2013 15:49:00 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Oleh Cc: 14975-done@debbugs.gnu.org Hi Oleh, Oleh writes: > Currently, this function behaves unconditionally > as if `org-clock-sound' was set to t. > > I attach a patch of how I fixed it for my needs: Please send those patches to the org-mode list first. I applied it but added a ChangeLog entry in the commit message and the TINYCHANGE change cookie that helps us track small changes by contributors who did not assign their copyright to the FSF (yet). Thanks for catching this, -- Bastien