emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: Oleh <o.krehel@tue.nl>
Cc: 14975-done@debbugs.gnu.org
Subject: bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound'
Date: Tue, 30 Jul 2013 12:46:50 +0200	[thread overview]
Message-ID: <87vc3sjpet.fsf__26121.076118625$1375181335$gmane$org@bzg.ath.cx> (raw)
In-Reply-To: <87a9l67q2b.fsf@tue.nl> (Oleh's message of "Sun, 28 Jul 2013 15:49:00 +0200")

Hi Oleh,

Oleh <o.krehel@tue.nl> writes:

> Currently, this function behaves unconditionally
> as if `org-clock-sound' was set to t.
>
> I attach a patch of how I fixed it for my needs:

Please send those patches to the org-mode list first.

I applied it but added a ChangeLog entry in the commit message
and the TINYCHANGE change cookie that helps us track small changes
by contributors who did not assign their copyright to the FSF (yet).

Thanks for catching this,

-- 
 Bastien

       reply	other threads:[~2013-07-30 10:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87a9l67q2b.fsf@tue.nl>
2013-07-30 10:46 ` Bastien [this message]
2013-07-30 10:50   ` bug#14975: 24.3; org-mode's `org-clock-notify-once-if-expired' doesn't respect `org-clock-sound' Bastien
2013-07-30 15:53     ` Glenn Morris
     [not found]     ` <7ktxjcgi2o.fsf@fencepost.gnu.org>
2013-07-30 17:22       ` Bastien
2013-07-30 17:27         ` Glenn Morris
2013-07-30 18:24           ` Stefan Monnier
2013-07-30 20:54           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87vc3sjpet.fsf__26121.076118625$1375181335$gmane$org@bzg.ath.cx' \
    --to=bzg@altern.org \
    --cc=14975-done@debbugs.gnu.org \
    --cc=o.krehel@tue.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).