From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Use of deprecated org-log-note-marker variable in outshine Date: Fri, 08 Jan 2016 14:21:41 +0100 Message-ID: <87vb74p5p6.fsf@nicolasgoaziou.fr> References: <87twmpny4m.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHWxL-0005Ge-Hl for emacs-orgmode@gnu.org; Fri, 08 Jan 2016 08:19:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHWxG-0006mI-Hs for emacs-orgmode@gnu.org; Fri, 08 Jan 2016 08:19:51 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHWxG-0006lK-4I for emacs-orgmode@gnu.org; Fri, 08 Jan 2016 08:19:46 -0500 In-Reply-To: (Kaushal Modi's message of "Thu, 7 Jan 2016 11:56:40 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Kaushal Modi Cc: emacs-org list , Thorsten Jolitz Hello, Kaushal Modi writes: >> Was it just removed, or rather renamed or replaced by something else? >> Maybe the fix would be trivial if somebody with insights about the >> change could give some hints? > > I have never needed to use this function, so I cannot comment on it. So > asking Nicolas for help regarding this. Actually, it was a mistake to remove the variable in the first place. As a consequence, I re-introduced it in master. However, it doesn't store the same location as before, i.e., it merely points to the entry where the note is going to be added instead of the accurate location for the note. As a first approximation, I think (with-current-buffer (marker-buffer org-log-note-marker) (goto-char (org-log-note-marker)) (copy-marker (org-log-beginning))) is close to what `org-log-note-marker' used to be. Regards, -- Nicolas Goaziou