From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= Subject: Re: M-S-RET doesn't work anymore? Date: Thu, 24 Jan 2019 20:47:14 +0100 Message-ID: <87va2dyh19.fsf@gmail.com> References: <87y37bup0p.fsf@norang.ca> <84va2fhzeu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:44385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gml3p-0006LG-6K for emacs-orgmode@gnu.org; Thu, 24 Jan 2019 14:53:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmky8-0000ow-EP for emacs-orgmode@gnu.org; Thu, 24 Jan 2019 14:47:21 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:44492) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gmky8-0000oG-8h for emacs-orgmode@gnu.org; Thu, 24 Jan 2019 14:47:20 -0500 Received: by mail-wr1-x432.google.com with SMTP id z5so7796515wrt.11 for ; Thu, 24 Jan 2019 11:47:19 -0800 (PST) In-Reply-To: (Kaushal Modi's message of "Wed, 23 Jan 2019 16:04:24 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Kaushal Modi Cc: Bernt Hansen , Marco Wahl , emacs-org list , Nicolas Goaziou Kaushal Modi writes: > On Wed, Jan 23, 2019 at 3:54 PM Marco Wahl wrot= e: > > As a workaround you can evaluate the lines (that were active before the > commit) > > (org-defkey org-mode-map (kbd "S-") #'org-table-copy-down) > (org-defkey org-mode-map (kbd "M-S-") #'org-insert-todo-heading) > (org-defkey org-mode-map (kbd "ESC S-") #'org-insert-todo-headin= g) > > or put them into your init file AFAICS. > > Yep, that commit broke the - bindings for me too. I'll have to do= the same. > > Copying Kevin who originally requested the change of these bindings (this= switching of bindings between RET and feels like dejavu to me .. = I have seen this done before in Org repo). > > Is this a reliable fix to add these lines to the source code again? > To be honest I don't see clearly. > > May be those keys should be bound to both RET and variants?=20 > > For Emacs GUI, I think that the variant is needed, RET does noth= ing. Gah! Apologies for the breakage. I assumed that in GUI frames, since is translated to RET when the former is not bound explicitly[1], *modifier*- would also be translated to *modifier*-RET, but that does not seem to be the case[2]. My previous experience with M-RET in markdown-mode[3] led me to assume I could suggest this change without breaking anything=E2=80=A6 Next time I'll know better and write those unit tests :) Thank you for catching this and again, sorry for the disruption. [1]: In fundamental-mode: C-h k =E2=87=92 RET (translated from ) runs the command newline=E2=80= =A6 [2]: In fundamental-mode: M-: (global-set-key (kbd "S-RET") (lambda () (interactive) (message "fo= o"))) C-h k S- =E2=87=92 RET (translated from ) runs the command newline=E2= =80=A6 M-: (global-set-key (kbd "M-S-RET") (lambda () (interactive) (message "= bar"))) C-h M-S- =E2=87=92 is undefined M-: (global-set-key (kbd "M-RET") (lambda () (interactive) (message "ba= z"))) C-h M- =E2=87=92 M-RET (translated from ) runs the command (lambda= =E2=80=A6) [3]: https://github.com/jrblevin/markdown-mode/commit/c0fc52461e845baa3c55d= 9b6f9e67c451a9ffa8d