From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2B+qCFwEfF8rDwAA0tVLHw (envelope-from ) for ; Tue, 06 Oct 2020 05:45:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id AC9yBFwEfF8xWQAAbx9fmQ (envelope-from ) for ; Tue, 06 Oct 2020 05:45:00 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 345879400BF for ; Tue, 6 Oct 2020 05:44:59 +0000 (UTC) Received: from localhost ([::1]:60234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPfmS-0005x3-9p for larch@yhetil.org; Tue, 06 Oct 2020 01:44:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPfm2-0005ve-Os for emacs-orgmode@gnu.org; Tue, 06 Oct 2020 01:44:30 -0400 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]:45838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPfm0-0005Ih-QD for emacs-orgmode@gnu.org; Tue, 06 Oct 2020 01:44:30 -0400 Received: by mail-qt1-x844.google.com with SMTP id 10so12068728qtx.12 for ; Mon, 05 Oct 2020 22:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=seDv1kk8S3QIM1ItU9a7LJNXGHYBK9zRhZZV6hFkIYw=; b=bSFN02j5yqSmBNHJJfkAhaCCn/XZ0M9p+hTTRuKYvY8E1a4fJPXbg/FppkFGHgjxeo uBuh2hBoTzj7Zs0cXBJVpnIEmU/jUVGdCAL8M4e8J0gAnS0QJ8AtLrhhA6ITcpIzE7fz w+dg/MjYf9VvFCwbaBanqHZL+tVnA9RhF7sRNJs2Ura/B7efPpd/NOwKcCl87i1cWk+l Q67cxkq2bWCN4tw0X2xXX5djAmvt8SjfLbjhaZlxQAt0At1/e1Q3RcyYEPqBG3JgL1it faGlNYWy7puToAxacE/cc4ptbDMuaDYpsmmhECnkMlVzNulG2+LoH0UhQThbrSgTy42/ IQAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=seDv1kk8S3QIM1ItU9a7LJNXGHYBK9zRhZZV6hFkIYw=; b=TlPCCLKk/STCPD2kjFrTxsI/2zr/L11HTBNhpJDgADJG9FesgALcjyAfAhYm3//jip mGzXggfrXt/7k5EBrbysTlKJNTlBsRShk0EYC+5uDbYdl2N4Aiyoy6WmtcjkASW6OY6U 2DN4NDfkYYg6NVJ85zcbFNslgNn8KuFUk5jkwKs2twUaq1OAjCiHyylkSLPehCmmpEpI ETXUK9oBPVwRjmgYVKkm239kketcLtqi6MgHUKqxZdRQ69QHPA3DG2MDvke2IsNEYO3C Wc2pbn+b28k0WgEsmEB3JaCiRo0ytDv8+x0IozFXQ5zy/MDupAjNAzLfTrQXmrRCuZiZ gjRg== X-Gm-Message-State: AOAM531iocqX+Enu0CLWE5AZSa4K/2KzQ6JKl9blSOdHY1cSc3z494QN NcQwNkxZi4XSRJQ77txDTyMSnrxdLwk5Gw== X-Google-Smtp-Source: ABdhPJzL4l9PEGz957SuOKg7S4d94mQtJ7BzfU3kqUK2oJWQfOiY/xC/ZXrR+RneJCHCC/qEYOmw+w== X-Received: by 2002:ac8:6056:: with SMTP id k22mr3444087qtm.71.1601963066775; Mon, 05 Oct 2020 22:44:26 -0700 (PDT) Received: from arch ([2601:8b:c300:1024:1266:d0ff:1635:f964]) by smtp.gmail.com with ESMTPSA id v30sm1651298qtj.52.2020.10.05.22.44.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 22:44:25 -0700 (PDT) User-agent: mu4e 1.5.5; emacs 28.0.50 From: No Wayman To: emacs-orgmode@gnu.org Subject: Bug: [PATCH] org-agenda: "Invalid face reference: t" errors [9.4 (release_9.4-49-g4b150d @ /home/n/.emacs.d/straight/build/org/)] Date: Tue, 06 Oct 2020 01:44:24 -0400 Message-ID: <87v9fnc3if.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::844; envelope-from=iarchivedmywholelife@gmail.com; helo=mail-qt1-x844.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=bSFN02j5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: yILR6r7puTGJ --=-=-= Content-Type: text/plain; format=flowed I noticed recently that my message buffer was getting clobbered with thousands of Invalid face reference errors when moving point around an org-agenda buffer. e.g.: > Invalid face reference: t [4519 times] Git bisect points to commit 7a12e149907b5921011710d869b7554c35859c89 > org.el (org-display-outline-path): Fix faces of the message > > * lisp/org.el (org-display-outline-path): Set :height as the > default face height, and don't change other face attributes. > > See a3576543f for a previous fix, and this discussion: > As a workaround, setting `org-agenda-show-outline-path' to nil prevents the errors. I believe the face spec in the call to `add-face-text-property' in `org-display-outline-path' is incorrect. The attached patch replaces it with an anonymous face, which works on my end. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-org.el-org-display-outline-path-Fix-invalid-face-ref.patch Content-Description: org-agenda-invalid-face-ref-fix >From 4b150d7ca3f8d7d9fe30f6b562b35a5f4072e5e1 Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Tue, 6 Oct 2020 01:30:09 -0400 Subject: [PATCH] org.el (org-display-outline-path): Fix invalid face reference error * lisp/org.el (org-display-outline-path): Use an anonymous face when adding default :height to outline path --- lisp/org.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index 425e9391b..beb830b36 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -8057,7 +8057,7 @@ If JUST-RETURN-STRING is non-nil, return a string, don't display a message." (and file bfn (concat (file-name-nondirectory bfn) separator)) separator)) (add-face-text-property 0 (length res) - `((t :height ,(face-attribute 'default :height))) + `(:height ,(face-attribute 'default :height)) nil res) (if just-return-string res -- 2.28.0 --=-=-=--