emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jack Kamm <jackkamm@gmail.com>
To: Augusto Stoffel <arstoffel@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: Bug: ob-python issue in Emacs 28 [9.4.4]
Date: Mon, 13 Sep 2021 22:56:13 -0700	[thread overview]
Message-ID: <87v933bszm.fsf@gmail.com> (raw)
In-Reply-To: <875yv61ej9.fsf@gmail.com>

Hi Augusto,

> In Emacs 28, `python-shell-send-string' prints an additional newline
> between the prompt and output (among other things, so you can tell
> whether or not the inferior process is busy at any given time).
>
> However, this interferes with ob-python, see e.g.
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=50514

Thanks for reporting this, and also for your recent improvements to
python.el.

Would you be willing to update your patch to use

(if (version< emacs-version "28") 0 1)

And add a commit message and changelog, so we can push it to master?

> As a permanent solution, I would suggest to replace org-babel-chomp
> and actually strip whitespace from both ends of the string outputted
> from the Python interpreter.  (IPython even has a configuration option
> to add extra whitespace before or after the output.)

I think this would be problematic, because then it would be impossible
to print output with leading or trailing whitespace, which it should be
possible to do.

Best,
Jack


  reply	other threads:[~2021-09-14  5:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12  6:41 Bug: ob-python issue in Emacs 28 [9.4.4] Augusto Stoffel
2021-09-14  5:56 ` Jack Kamm [this message]
2021-09-14 19:40   ` Augusto Stoffel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v933bszm.fsf@gmail.com \
    --to=jackkamm@gmail.com \
    --cc=arstoffel@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).