From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gLP7B9p+nGH/wAAAgWs5BA (envelope-from ) for ; Tue, 23 Nov 2021 06:40:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yGq1A9p+nGELLwAAB5/wlQ (envelope-from ) for ; Tue, 23 Nov 2021 05:40:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9E098342DE for ; Tue, 23 Nov 2021 06:40:41 +0100 (CET) Received: from localhost ([::1]:49538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpOXn-00058L-Bj for larch@yhetil.org; Tue, 23 Nov 2021 00:40:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpOWB-000589-Pu for emacs-orgmode@gnu.org; Tue, 23 Nov 2021 00:39:00 -0500 Received: from [2607:f8b0:4864:20::42d] (port=44859 helo=mail-pf1-x42d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpOW8-0001HG-NM for emacs-orgmode@gnu.org; Tue, 23 Nov 2021 00:38:58 -0500 Received: by mail-pf1-x42d.google.com with SMTP id b68so18293090pfg.11 for ; Mon, 22 Nov 2021 21:38:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=ww534vy2sR4il1nQczF4Zx2/loIYIHwdYg0bgJfouyM=; b=qjEIwPu2ZQbNjtWw7Y1TpWb6K6S/6vjGUWIbGxUWRdcJNaHyjXs90eBkhCC71R9z6m 3KluHQmxyy368eyjA39Dz6Ct7EiawOMnWlwIGo4LW5nQZPYilQdobUyqt3ZMMRlbEsnr hVNjGfb9oNnmI8wO3ZNAd6g+Y3Cdl+8osFJjZ+s8RyMrDEMePTQbl7L+m4DsRTsxw2xg 2Dt9c79DEZSAWgzl2mZ0VunRLBjky/QGB+ByTfulNbXwNm3bfW1FYCelX+C0XosuL7At DlAFJNCVqxWMpW8u/3+qrYUVuRnS6i9y+hBgheQ1HWdzK7oej83JhUH69svD64mmu+cz g9Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:cc:subject:in-reply-to:references :date:message-id:mime-version; bh=ww534vy2sR4il1nQczF4Zx2/loIYIHwdYg0bgJfouyM=; b=K2f3KsTpmYhzHtTCdirLoVc62X0jgiLmFm9YKQIfywczoarNN1teOaNAxoAyUFzRVp LwDeUCS7NEXbvD4BKi4UZU/GAgz4KvtzJ0Tte3r9nQFN8vvDO6ZKuOMUAM4t+QkPbmey /22ASwYNOsSWnP+7tC/YzVwyBproMS+MMcQTOKNKsrHf5oTFzbiDvUKwexUwt+MJl6sG bW6Lg6QOqTK6S9zghSkpOX6/J5ImF4KTskZmT//Le8kCLwDM4BYt4q6EVZSZF1Q17zZd pLsA18dS1QgnccukC0pYVJmo6EUaXNIkmhKUmv+4OJDyyBXmF0uoIRv5Ic00AZTFgjCh NAmA== X-Gm-Message-State: AOAM531aXixuvoWEOMS6RSjI09Xo/jJw6TANebyNKL1W4xKqfJR7c37R D6P6tvATKtVQnVRiHsSioTtqQPfeJn8= X-Google-Smtp-Source: ABdhPJxkhIUgZFqYD0OOgpKYxakx6HygknyKy5sQRfKI3koPpjpUe4syQfTLLHri2iZZnMims3272w== X-Received: by 2002:a63:8948:: with SMTP id v69mr1937273pgd.250.1637645933568; Mon, 22 Nov 2021 21:38:53 -0800 (PST) Received: from ryzen3950 (c-208-82-98-189.rev.sailinternet.net. [208.82.98.189]) by smtp.gmail.com with ESMTPSA id g17sm10776987pfv.136.2021.11.22.21.38.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Nov 2021 21:38:52 -0800 (PST) From: Matt Huszagh To: Timothy Subject: Re: [PATCH] Fix regex for determining image width from attribute In-Reply-To: <8735nnlaef.fsf@gmail.com> References: <87czmtuy0p.fsf@gmail.com> <87ilwl71gh.fsf@gmail.com> <87a6hxuw0y.fsf@gmail.com> <877dd07fnb.fsf@gmail.com> <8735noqig0.fsf@gmail.com> <87wnl05ag6.fsf@gmail.com> <87y25fq5d2.fsf@gmail.com> <8735nnlaef.fsf@gmail.com> Date: Mon, 22 Nov 2021 21:38:51 -0800 Message-ID: <87v90jph1w.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::42d (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=huszaghmatt@gmail.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637646041; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ww534vy2sR4il1nQczF4Zx2/loIYIHwdYg0bgJfouyM=; b=M3JueEqQMpORPscJbrpNC4Rlh9OJ5bvMIp3q6rkH1hOZPRI1uo5z00Tbi8hb2rWYP8mKYP eDrHXnXV5PlzuSuzAP2ObANAiVnaTD76vZ0KE3rnA5TYOQWOFpkWgHIbXygFS40nR+REct gtth0Q5lad5oZQZjPdq+tSM1czLxlVTVhFzqh7AYVAWe6GfkY286t1KkgYijqniERFOMB0 5Nx99BZ0L/Vo1MJWEobilJfGPAMfwFE+XYtA0uXnaAzHrUm9AV3cYqeqrx/ZO+dVrloySf uUWDoAXNBzVVJ/a46d0I6EcPt0dEGqY8Q85zm7yRW+U0qXAAyo+eDzv7dmZ30Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637646041; a=rsa-sha256; cv=none; b=QzlFgF7rqw4qAz86z6VGBlP2P1ifcZfpieqiQPCgY6OgYD+qgoxUvApGLuUaCcQDVyGKPh /UOHfDA61BCPWuMvmAcR43yZfwDFi48m/yEevW8jimYFPg3VSik7rgEJajScx7lqZ6HlMv 2P36roZhhIqw2u3PUZM/0L2Zg3xPQB3m1QH+uW8xKjxFpyahIo4CfhktNMuhQ7GzRVW38D l+V2MPSnWCa9D8dLvzd6FjSE75tfJyQwAkSHaI/L1i2r94g71lszN0sLacX3f/VaDaS9D3 HFfkoBSY45WlHJNedIBZNOjs4U028YOa4JYGtw6gWi47/z+utWgNa6LQkiutHA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=qjEIwPu2; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.78 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=qjEIwPu2; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 9E098342DE X-Spam-Score: -1.78 X-Migadu-Scanner: scn1.migadu.com X-TUID: QUsPCYjZX7xF --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Timothy writes: > This issue and Kyle=E2=80=99s change were resolved in another thread, jus= t FYI this is > fixed now. Thanks for mentioning it. There is just one small residual error I could find. This patch fixes it. Matt --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-org.el-Fix-string-match-p-function-arguments.patch >From 3724b5bcadab6900367848dadcf470494b5b0d79 Mon Sep 17 00:00:00 2001 From: Matt Huszagh Date: Mon, 22 Nov 2021 21:36:03 -0800 Subject: [PATCH] org.el: Fix string-match-p function arguments * lisp/org.el (org-display-inline-image--width): string-match-p requires 2 arguments, but only one was given. --- lisp/org.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index 736b743c7..308bb7d51 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -16867,7 +16867,7 @@ buffer boundaries with possible narrowing." ((string= attr-width "t") nil) ;; Fallback to `org-image-actual-width' if no interprable width is given. ((or (null attr-width) - (string-match-p "\\`[^0-9]")) + (string-match-p "\\`[^0-9]" attr-width)) (car org-image-actual-width)) ;; Convert numeric widths to numbers, converting percentages. ((string-match-p "\\`[0-9.]+%" attr-width) -- 2.31.1 --=-=-=--