From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EKPfCAwTH2MZZQEAbAwnHQ (envelope-from ) for ; Mon, 12 Sep 2022 13:07:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id SJ6ECAwTH2PvPgEAauVa8A (envelope-from ) for ; Mon, 12 Sep 2022 13:07:56 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BB431B4E5 for ; Mon, 12 Sep 2022 13:07:55 +0200 (CEST) Received: from localhost ([::1]:35018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXhI9-00053U-E6 for larch@yhetil.org; Mon, 12 Sep 2022 07:07:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXhCc-0003fW-1C for emacs-orgmode@gnu.org; Mon, 12 Sep 2022 07:02:10 -0400 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]:34732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXhCU-00056U-G5 for emacs-orgmode@gnu.org; Mon, 12 Sep 2022 07:02:09 -0400 Received: by mail-pg1-x532.google.com with SMTP id i19so4646447pgi.1 for ; Mon, 12 Sep 2022 04:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=ew6g5kVJ4cOH2fVXK9mIbKNVldVVU/aZDHXFpgZt/TM=; b=ArfAmQAJwqeYTUR0zWKqyunkh4EHcnAjDpijLH1XA1UymM0P9OGdJqLg5wrZNsVs9J r5rnIehTOPLkNd08MYJ1wT9eSgJKqjBzteOxBoVoVoxuYFO7WuerM2Bx+z//jcsDLo3i U8l0YYj8RKl76kvmBuJmwS3qqsOYK6n1zS/VmcjuVQ7EKVpTED8CJJ7yR0UF1orY2X+8 Na5OzEg2uKb4YQJgrBaRNsyzDktkxDxCQK95Rtjs8/TqaUbweJyJWmMCJFu71gcVa9+T E6dR8eqkTa3jfWfg0f4uA7JpyQKIQ3q/olmaNrgdaP3ncS0UMgsHfG8ebODEe26WQJpm UMwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=ew6g5kVJ4cOH2fVXK9mIbKNVldVVU/aZDHXFpgZt/TM=; b=suiPIK9L4tjDF8wFLrVXr5YkLfP8BgwE63xvfEjSJcWLz62pNpZQG+giPYwavF18ZZ ePFzflRGDygcbBKGUK14WUhns1NSxPNlY68rkMf974wwjG1x4OOlgwdborFP9uNlO5L3 n3eLH1FAKp1FVljCzD1Q3EELxiF+wMUsRGqweCDc4YqFr9pMjdPtPBvOF/27uAfyhCSV BJYXZW4NoKds9JKhp/4UQsSXduMAYJgf0H2foNSUC16xdsJyE3cziYkEZMTxazw3/vmE 4ta6nagE5MhUZHbPr6GsgZRsrxqZhuxpncpyn4wrf3o5u5iZMSeYl8dNnOKyHj2HQDm9 ySLw== X-Gm-Message-State: ACgBeo2cX5CcjxKb5ihUT9rAclbXt5xf/itOlVyYW+AZiMbAsx2S7GtC sVc1rTCCfoXqfDOWDimbmPg= X-Google-Smtp-Source: AA6agR5jk5cFVYc5fBfm+xy11dC92/D8ZB6zzZ8GJ+7SMzmVVa582x2iqPak9K7qTatdd6ztdMQLAA== X-Received: by 2002:a05:6a00:1892:b0:540:acee:29e8 with SMTP id x18-20020a056a00189200b00540acee29e8mr19838112pfh.1.1662980520933; Mon, 12 Sep 2022 04:02:00 -0700 (PDT) Received: from localhost ([2409:8a70:2bc:c850:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id a15-20020aa7970f000000b0053b208b55d1sm5136392pfg.85.2022.09.12.04.01.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 04:02:00 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH v2] Re: Adding target and custom id links doesn't ask for description In-Reply-To: References: <87a68c4pyc.fsf@localhost> <8735e091pn.fsf@localhost> Date: Mon, 12 Sep 2022 19:02:53 +0800 Message-ID: <87v8psvorm.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::532; envelope-from=yantar92@gmail.com; helo=mail-pg1-x532.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662980876; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ew6g5kVJ4cOH2fVXK9mIbKNVldVVU/aZDHXFpgZt/TM=; b=ur/4/7hfXB8HiOsTxP42GXZVVBJQcTu+71rTTl4tqjJjzIXRQq6b/W/0Uswo8O1nnERu2Z FQUYQkMeLgtjglmnaZNhn3eqDl+Hv+ASj1df9mf+DeLIZHJJxa2GVQW8TUOSFbD7XusYZF fq3PF4zFdqMfX9OW6t6L3wBWXP4zWGR//gb7UTfRxd+th2LtPMFh/lQ3YSh1mZFMISZp6k 1DvLmqaVNDtylwybnJPZ1FZd52gVOkgYKoX8RTPoQb2/jWqZrwEbGdBmA/71yu1BtrTsj9 +T3DUlpckcei/OUhb3NWve7npSTrMEEtcE4cedw0R4HJSJeNUSi7OFWJ3CsU1A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662980876; a=rsa-sha256; cv=none; b=ebNy0Iut7q4AbLQ4nA9yPGZ21Hi6SjXHvX1n1xuk6jktSF3i64jqPHTQSFeNqFiwFDWnT1 I3otb2ppzXgiwaFHzl2+zrHnh+ThNoerWNfBSiwc7epkf4dtPes3jSLmFHxeBrT2wPVZO0 LHgUdWt6Y5PZOnnSAr+IZar2khOkmgu7pvYWxG7TGUmmuWDscspMxLOr23xax/tcV6IIZ+ dRGRktRCAT3WNH7or6GyUMDeEjRFBBTfnUhyWnuJqnu34tW23AWpNx9MDS9Yr+LtRcdwUD DTZr63Szzg9YxZ8vdWuYAFMW9MdPXarArFnSfOtskfiYh+LTisniKTritUdJvQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ArfAmQAJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.91 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ArfAmQAJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BB431B4E5 X-Spam-Score: -8.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6QP8GjXYsHtp Max Nikulin writes: > Unfortunately, your patch does not fix the real issue. The title (not > nil) should be saved for link description when the heading contains the > CUSTOM_ID property. I tried to address it in the following patches: > > Max Nikulin. Re: Bug: org-store-link uses CUSTOM_ID instead of target > point. Sat, 6 Nov 2021 19:51:29 +0700. > https://list.orgmode.org/e2c807a7-1924-6f08-9e63-4f70aee9d3b5@gmail.com Does it mean that my patch + the patch you linked can be used to fix the issue reported in this thread? -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92