From: Ihor Radchenko <yantar92@posteo.net>
To: Daniel Kraus <daniel@kraus.my>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch] ob-clojure: Fix results output
Date: Wed, 15 Mar 2023 10:20:21 +0000 [thread overview]
Message-ID: <87v8j2qpsq.fsf@localhost> (raw)
In-Reply-To: <87y1nzflur.fsf@kraus.my>
Daniel Kraus <daniel@kraus.my> writes:
> Ups, I attached the wrong one.
> Here the correct patch..
Thanks!
Some more comments ;)
> (defcustom org-babel-clojure-backend (cond
> ((executable-find "bb") 'babashka)
> - ((executable-find "nbb") 'nbb)
> + ((executable-find "clojure") 'clojure-cli)
> ((featurep 'cider) 'cider)
> ((featurep 'inf-clojure) 'inf-clojure)
> ((featurep 'slime) 'slime)
> (t nil))
What will happen with users who customized `org-babel-clojure-backend'
to 'nbb in the past?
> +(defcustom org-babel-clojurescript-backend
> + (cond
> + ((or (executable-find "nbb") (executable-find "npx")) 'nbb)
> + ((featurep 'cider) 'cider)
> + (t nil))
> + "Backend used to evaluate Clojure code blocks."
This docstring is exactly the same with `org-babel-clojure-backend'.
What is the difference?
I think ""Backend used to evaluate ClojureScript code blocks." will be
more clear. I feel that other docstrings may also need to be clarified
depending whether they affect Clojure or ClojureScript blocks.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-03-15 10:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 15:40 [patch] ob-clojure: Fix results output Daniel Kraus
2023-03-10 12:35 ` Ihor Radchenko
2023-03-13 14:01 ` Daniel Kraus
2023-03-14 12:35 ` Ihor Radchenko
2023-03-14 13:38 ` Daniel Kraus
2023-03-14 14:27 ` Daniel Kraus
2023-03-15 10:20 ` Ihor Radchenko [this message]
2023-03-15 11:22 ` Daniel Kraus
2023-03-16 10:19 ` Ihor Radchenko
2023-03-19 8:07 ` Ihor Radchenko
2023-03-19 20:43 ` Daniel Kraus
2023-03-22 10:48 ` Ihor Radchenko
2023-03-23 11:31 ` Daniel Kraus
2023-03-23 11:52 ` Ihor Radchenko
2023-03-23 12:29 ` Daniel Kraus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8j2qpsq.fsf@localhost \
--to=yantar92@posteo.net \
--cc=daniel@kraus.my \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).