From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 2MXzEw94F2TTzAAASxT56A (envelope-from ) for ; Sun, 19 Mar 2023 22:01:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MPgEFA94F2SS4wAAauVa8A (envelope-from ) for ; Sun, 19 Mar 2023 22:01:03 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0A87BA5BA for ; Sun, 19 Mar 2023 22:01:02 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pe08V-0006Vn-Gi; Sun, 19 Mar 2023 17:00:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pe08T-0006Ux-8f for emacs-orgmode@gnu.org; Sun, 19 Mar 2023 17:00:13 -0400 Received: from mout-p-202.mailbox.org ([2001:67c:2050:0:465::202]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pe08Q-00018d-7V for emacs-orgmode@gnu.org; Sun, 19 Mar 2023 17:00:12 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4Pfqxv2N77z9sSS; Sun, 19 Mar 2023 22:00:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kraus.my; s=MBO0001; t=1679259603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JfRZNTZ93lN4v7a8jKeaMUDDG6WGWFJFg0YlX2YkraA=; b=mVmSJVzk/ZKPPBgmpgJOIevP8vKX96aYb8ywQVd1rBCARARONVpp5Oau43fCSjQS6U2gTe CI2K1oCBZUWiEMsvHwzrnllzA9bSqGhl7NgrzGzRocAxgoVHB9WFqagch+a8aIlhG2ooYl naE67AuObVvJT0WlCIx/GIXAqRJN1PDqy2BC62H1Fm6QzFWT5OkE7kDnPXrG8GWBcdusjW Z7UvuU4fGTDOPIqFGKhw98fHeE/Y+S98ybT2lxbp7trZCRbYhosvNMpzSMo2zC9YmKkkme dFnw9nQOMVhe+etI1kzsATnEVxgUagp+TrEimIs2UVx3PgDs+sYH896Xr2sjdg== References: <87o7oqxn6r.fsf@localhost> From: Daniel Kraus To: Ihor Radchenko Cc: stardiviner , Org-mode Subject: Re: [SUGGESTION] separate ob-clojure.el into Clojure part ob-clojure.el and ClojureScript part ob-clojurescript.el Date: Sun, 19 Mar 2023 21:46:46 +0100 In-reply-to: <87o7oqxn6r.fsf@localhost> Message-ID: <87v8iwe9tl.fsf@kraus.my> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=2001:67c:2050:0:465::202; envelope-from=daniel@kraus.my; helo=mout-p-202.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kraus.my header.s=MBO0001 header.b=mVmSJVzk; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679259663; a=rsa-sha256; cv=none; b=PYc4N4AsNjKlbjbWLz81N9fUZ47/c+6aFPkmhVHwFN5IbKaOMH31o8TM0lKs25uahB834Y b5gWKh/2mqZIpm1rdwMxDMdeTdTaqMv9f+4zip/gvBJt5YXBmEWUpfx9C8KXRdkeq/BTKY 4G92q8GFyLsGEH/faSwqZswpQZLHkqF8Afgkld4G2b1dpfoxjOGG5B77znbLHp3IPW+/0X MrZapNWaDqMY1KQKlPbv02eNcaPeoHbow6i2ExLl+0EW7TyD3mr0jsAxs0nrh4WQj4RPRV Hs9RT/eodnK3reIVy6FoXSXsgjLtjkfushOv4uw7nh2xV4C4u2PSrje0XPpt+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679259663; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JfRZNTZ93lN4v7a8jKeaMUDDG6WGWFJFg0YlX2YkraA=; b=KdNFxI/uMguIaEASU6ooYCoTzd+mOaoJYGDdZNtblEZ2CLB376HB4S7f0YzaA+i21T0xFx sX3JmzY0Ch8EWi0e/GhuNS70WORbzhaSwxGq16jzkQ1JHd3CQFKrRzeZAlTwWPrMfZcj1t 0nd6I7wE8uGB+BHuEmfl3bwz4TMKbz72kozHeyMzGN3fx8Hi4lbymX6zzDmCwDAl8nSdQk 54hhc1TKP+UHwsm6qTaCV0GwYcJGw7+DhGzUM/x50D8KFLohpGvCOulOeN2SPvHHs5LEcF ZeXEcelQaaihSD2weZHCL4fDTCAA+WaJJxcgm7xMXP3oglJhydKrPPvNrUap2w== X-Migadu-Spam-Score: -4.11 X-Spam-Score: -4.11 X-Migadu-Queue-Id: 0A87BA5BA X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kraus.my header.s=MBO0001 header.b=mVmSJVzk; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: GlNaHrETa0PF Ihor Radchenko writes: > stardiviner writes: > >> For now, ob-clojure.el contains lot of code for ClojureScript. Only some >> code has same functionality. Like CIDER backend. In the future, >> ClojureScript part code will increase and different. So I suggest >> separate them into two source code files. >> >> WDYT? I'm not opposed to it, but I'm also not sure if it's worth it. Without whitespace and comments, ob-clojure is only 261 LOC and without having a closer look I would guess we would have to duplicate maybe 150 of those in ob-clojurescript. It would make the implementation a bit cleaner but at the cost of code duplication. I would say we wait until the ClojureScript part really grows bigger and then do a split if that should ever happen. I could also see a scenario where we add support for ClojureDart and/or ClojureCLR to ob-clojure. It would be very simple if they have a CLI like the JVM Clojure. > The only downside is that people might need to > (require 'ob-clojurescript) > I am thinking if ob-core.el should try to automatically guess the > correct library to be loaded. We could just (require 'ob-clojurescript) inside ob-clojure.el ?! Cheers, Daniel