From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [PATCH] lisp/ob.el (org-babel-result-cond) Date: Tue, 11 Dec 2012 07:41:29 -0700 Message-ID: <87txrsmpy1.fsf@gmail.com> References: <877gotiqnp.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:56723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiUKV-0002fi-U7 for emacs-orgmode@gnu.org; Tue, 11 Dec 2012 13:13:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TiU5k-0004YB-Kd for emacs-orgmode@gnu.org; Tue, 11 Dec 2012 12:59:01 -0500 Received: from mail-da0-f41.google.com ([209.85.210.41]:56946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TiU5k-0004Y2-EC for emacs-orgmode@gnu.org; Tue, 11 Dec 2012 12:58:04 -0500 Received: by mail-da0-f41.google.com with SMTP id e20so1764158dak.0 for ; Tue, 11 Dec 2012 09:58:03 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Achim Gratz writes: > This has been in there for a while and only been visible due to > byte-compiler warnings about free variable result-params. Either the > tests don't really exercise this code path well or we've been lucky that > result-params was bound to the correct value during all those calls. > The `result-params' variable is *always* in scope every time this macro is called. In fact previously the Babel language files were told to expect some variables to always be in scope without their being explicitly passed in as parameters. We've since begun passing these things explicitly to the language functions to appease the compiler. I'd like to apply this patch, however the format is not detected by git am. Could you re-generate this patch using git format-patch and attach the resulting file? Thanks, -- Eric Schulte http://cs.unm.edu/~eschulte