From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: Unclear org-icompleting-read interface Date: Thu, 25 Jun 2015 16:36:11 +0200 Message-ID: <87twtvlusk.fsf@gmx.us> References: <87vbecudww.fsf@gmail.com> <877fqryjyh.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z88Gm-0000ny-4T for emacs-orgmode@gnu.org; Thu, 25 Jun 2015 10:36:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z88Gg-0003Ox-7t for emacs-orgmode@gnu.org; Thu, 25 Jun 2015 10:36:48 -0400 Received: from plane.gmane.org ([80.91.229.3]:54292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z88Gg-0003OD-17 for emacs-orgmode@gnu.org; Thu, 25 Jun 2015 10:36:42 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Z88Ga-00025i-4R for emacs-orgmode@gnu.org; Thu, 25 Jun 2015 16:36:36 +0200 Received: from 90.163.164.75 ([90.163.164.75]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 25 Jun 2015 16:36:36 +0200 Received: from rasmus by 90.163.164.75 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 25 Jun 2015 16:36:36 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi, Nicolas Goaziou writes: > Oleh Krehel writes: > >> The current `org-icompleting-read' is defined as taking only `&rest >> args', which can be as many as 8, all of them without a name. >> >> I propose to update the definition to: >> >> (cl-defun org-icompleting-read (prompt collection >> &key predicate require-match >> initial-input hist def inherit-input-method) >> ;; ... >> ) > > I'd rather not use cl-defun in code base, which is slightly more > difficult to understand, and hardly unavoidable. Moreover, > `org-icompleting-read' is not harder to read as `completing-read' > anyway. I agree. It's confusing how the docstring and the λ is written, but it's just a "front-end" for completing-read. A reference to completing-read should be added to the docstring. >> This change would make the calls to `org-icompleting-read' much easier >> to read. > > While we're at it, I suggest instead to make `org-icompleting-read' an > obsolete alias for `completing-read' in Org 8.4. > `partial-completing-mode' is obsolete since Emacs 24.1. That was my "feeling" about org-icompleting-read as well last time I looked at it (also a message by Oleh). For org 8.4 we can also get rid of all the iswitchb stuff. Good times ahead... Rasmus -- This is the kind of tedious nonsense up with which I will not put