emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Thorsten Jolitz <tjolitz@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: Use of deprecated org-log-note-marker variable in outshine
Date: Thu, 07 Jan 2016 17:38:17 +0100	[thread overview]
Message-ID: <87twmpny4m.fsf@gmail.com> (raw)
In-Reply-To: CAFyQvY1gCBnv5axw-ZEcLE84eBzbJNYYVCm41OrKKmY9QEM_pw@mail.gmail.com

Kaushal Modi <kaushal.modi@gmail.com> writes:

Hi Kaushal,

> Recently the global variable org-log-note-marker was removed from
> org.el.
>
> But it is used in outshine.el as follows:
>
> (defadvice org-store-log-note (around org-store-log-note-around
> activate)
> "Outcomment inserted log-note in Outshine buffers."
> (let ((outshine-log-note-beg-marker
> ;; stay before inserted text
> (copy-marker org-log-note-marker nil))
> (outshine-log-note-end-marker
> ;; stay after inserted text
> (copy-marker org-log-note-marker t)))
> ad-do-it
> (unless (derived-mode-p 'org-mode 'org-agenda-mode)
> (comment-region outshine-log-note-beg-marker
> outshine-log-note-end-marker))
> (move-marker outshine-log-note-beg-marker nil)
> (move-marker outshine-log-note-end-marker nil)))
>
> So right now, I am getting this warning at emacs startup:
>
> ~/.emacs.d/elpa_25_0/outshine-20151203.802/outshine.elc:Warning:
> reference to
> free variable ‘org-log-note-marker’
>
> @ Thorsten, Nicolas: What would be the best way to fix that?

Was it just removed, or rather renamed or replaced by something else?
Maybe the fix would be trivial if somebody with insights about the
change could give some hints?

PS
Recently I managed to use Emacs/Org-mode more frequently again and even
follow the mailing list somehow, so I hope I can the change maintainance
state of the outshine libraries from 'unmaintained' to 'kind of
maintained' again.

-- 
cheers,
Thorsten

  reply	other threads:[~2016-01-07 16:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-06 23:09 Use of deprecated org-log-note-marker variable in outshine Kaushal Modi
2016-01-07 16:38 ` Thorsten Jolitz [this message]
2016-01-07 16:56   ` Kaushal Modi
2016-01-08 13:21     ` Nicolas Goaziou
2016-01-08 15:45       ` Kaushal Modi
2016-01-08 16:28       ` Nicolas Richard
2016-01-31 22:11         ` Nicolas Goaziou
2016-02-03 23:04       ` Thorsten Jolitz
2016-02-03 23:02 ` Thorsten Jolitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twmpny4m.fsf@gmail.com \
    --to=tjolitz@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).