From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: [PATCH 2/2] org-refile: optionally prefix refile targets with buffer name Date: Fri, 05 May 2017 19:23:25 -0400 Message-ID: <87tw4ysxaq.fsf@kyleam.com> References: <20170503175003.22151-2-seb@wirrsal.net> <20170503203046.31610-1-seb@wirrsal.net> <20170503203046.31610-2-seb@wirrsal.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6mZN-0004xA-LZ for emacs-orgmode@gnu.org; Fri, 05 May 2017 19:23:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6mZK-0005zp-Hv for emacs-orgmode@gnu.org; Fri, 05 May 2017 19:23:29 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:65297 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d6mZK-0005yx-F6 for emacs-orgmode@gnu.org; Fri, 05 May 2017 19:23:26 -0400 In-Reply-To: <20170503203046.31610-2-seb@wirrsal.net> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Sebastian =?utf-8?Q?Reu=C3=9Fe?= Cc: emacs-orgmode@gnu.org Sebastian Reu=C3=9Fe writes: > * org.el (org-refile-get-targets): Add case to optionally prefix > refile targets with the buffer name. > (org-refile-use-outline-path): Add new option setting and document. > > Having an option to use the buffer name as a prefix is convenient, > since this will work hand in hand with uniquify to only show those > parts of the filesystem path needed to disambiguate buffers of > identically named files, as opposed to prefixing refile targets with > the full filesystem path. Yeah, that does seem useful. > --- > lisp/org.el | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) I think this should be accompanied by an ORG-NEWS entry. > diff --git a/lisp/org.el b/lisp/org.el > index ad92f3b2e..342143d5a 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -2553,13 +2553,16 @@ (defcustom org-refile-use-outline-path nil > into the path. In this case, you can also stop the completion after > the file name, to get entries inserted as top level in the file. >=20=20 > -When `full-file-path', include the full file path." > +When `full-file-path', include the full file path. > + > +When `id', use the buffer name." The link between `id' and buffer name isn't obvious to me. I'm guessing that it's because it would be a unique ID for the file, whereas `file' would not. Perhaps `buffer' would be better? --=20 Kyle