emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Use cl-lib rather than cl variants in org-drill
@ 2017-07-14 19:57 Stig Brautaset
  2017-07-23  9:09 ` Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: Stig Brautaset @ 2017-07-14 19:57 UTC (permalink / raw)
  To: Org Mode

[-- Attachment #1: Type: text/plain, Size: 102 bytes --]

org-drill requires only cl-lib rather than cl, so should use cl-gensym
rather than gensym I believe.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0002-org-drill.el-use-cl-gensym-rather-than-gensym.patch --]
[-- Type: text/x-patch, Size: 796 bytes --]

From 1eef99d550e467bf4a3eaf6bdbe4d3a482f6c187 Mon Sep 17 00:00:00 2001
From: Stig Brautaset <stig@brautaset.org>
Date: Fri, 14 Jul 2017 20:45:37 +0100
Subject: [PATCH 2/3] org-drill.el: use cl-gensym rather than gensym

cl-lib is already required by this file, but cl is not.
---
 contrib/lisp/org-drill.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/lisp/org-drill.el b/contrib/lisp/org-drill.el
index fb578ab86..7c4a29930 100644
--- a/contrib/lisp/org-drill.el
+++ b/contrib/lisp/org-drill.el
@@ -622,7 +622,7 @@ regardless of whether the test was successful.")
 
 
 (defmacro pop-random (place)
-  (let ((idx (gensym)))
+  (let ((idx (cl-gensym)))
     `(if (null ,place)
          nil
        (let ((,idx (random* (length ,place))))
-- 
2.11.0 (Apple Git-81)


[-- Attachment #3: Type: text/plain, Size: 54 bytes --]


Stig
-- 
; GNU Emacs 26.0.50, Org mode version 9.0.9

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Use cl-lib rather than cl variants in org-drill
  2017-07-14 19:57 [PATCH] Use cl-lib rather than cl variants in org-drill Stig Brautaset
@ 2017-07-23  9:09 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2017-07-23  9:09 UTC (permalink / raw)
  To: Stig Brautaset; +Cc: Org Mode

Hello,

Stig Brautaset <stig@brautaset.org> writes:

> org-drill requires only cl-lib rather than cl, so should use cl-gensym
> rather than gensym I believe.
>
> From 1eef99d550e467bf4a3eaf6bdbe4d3a482f6c187 Mon Sep 17 00:00:00 2001
> From: Stig Brautaset <stig@brautaset.org>
> Date: Fri, 14 Jul 2017 20:45:37 +0100
> Subject: [PATCH 2/3] org-drill.el: use cl-gensym rather than gensym
>
> cl-lib is already required by this file, but cl is not.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-23  9:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-14 19:57 [PATCH] Use cl-lib rather than cl variants in org-drill Stig Brautaset
2017-07-23  9:09 ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).