From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id xy3FJHquGWCYfQAA0tVLHw (envelope-from ) for ; Tue, 02 Feb 2021 19:56:42 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UNPkH3quGWAjDgAAbx9fmQ (envelope-from ) for ; Tue, 02 Feb 2021 19:56:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 934079404FA for ; Tue, 2 Feb 2021 19:56:41 +0000 (UTC) Received: from localhost ([::1]:39202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l71my-0002GA-Hf for larch@yhetil.org; Tue, 02 Feb 2021 14:56:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l71lv-0002Fp-86 for emacs-orgmode@gnu.org; Tue, 02 Feb 2021 14:55:35 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:34936) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l71lp-0003eV-KS for emacs-orgmode@gnu.org; Tue, 02 Feb 2021 14:55:34 -0500 Received: by mail-pl1-x631.google.com with SMTP id g3so13111010plp.2 for ; Tue, 02 Feb 2021 11:55:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=C6/SpBUCctAQopOzpB6eJNiPK6LeRVWU+D8snoh1Xaw=; b=AHALZAdHEXwbyryjoVcm0mWwkBoXqs3n8/2fdng4C9mGV9n2eThZAgpWtsqqby2Yti EO8Z55ImRT6w+LG64Mc3qX20457sYniFgFFAox1LS91gXrayqSQrS7JnqRcEpnOOET0G WEV/NgTJEGPStRBj8xfY2eQVV7tUZMn0oeItjMsU58ulqtHNFEyuUxoGTqx2O2dYtitV ZH0MaDbmm8MZei82Lc5W1FI+tU8WAVBHQ/xFrMoTE5Etk8MH/k37/P5/clRuGaenoDnk gPzBGlOqGfD954PL+NaYIZtAXbDxK8FpgHP78GzTwM8h2l50XtVDW0XNVtVsfJzNBlih zJsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=C6/SpBUCctAQopOzpB6eJNiPK6LeRVWU+D8snoh1Xaw=; b=ebqLOzg9j558rpYby42cOzdBolHOAVo2ewN1SEhiyJihhvC9g+5QdBIuLvYsf3qqY0 5A8de7YAAAb+BK9P+tIHhwsgHucDmWia437rHo9+2ea+OfsBPA8AUZkzS+O4n/uVq0OS K+4du4kTG8Mc7dTqeihPy1qQdu6xol4eXpMOZptXYPOkg1feRw71/3YBNviPRpOPEQfE 0NBtidowEEbwwz3vUuoV7+yM0LxWuNu1ddRWd5FOFa813HXQEkXvXkmjCfv5rfaM5/xZ eEndSu0ZchLCNOx1Sjm413ce/u03u8p6jrGUX1Qovvghp8XxRveyCA/Zzk8dH37BX0jE BUSg== X-Gm-Message-State: AOAM532tsHqVlh+KiahgaoppN0WIBKTCZGYupSiq68G+xNNO9ARIwR4s T4G/c8E551vYzW4Izs0ZK7PDCOqpfJWKzA== X-Google-Smtp-Source: ABdhPJwG4HapNyzqJemLidn6JNi/A0yXeZnvr2itQbRoiiaAbumYk+hvmqw7BUELNusqjX0/H28tkQ== X-Received: by 2002:a17:90b:250:: with SMTP id fz16mr5895486pjb.227.1612295727401; Tue, 02 Feb 2021 11:55:27 -0800 (PST) Received: from tim-desktop (220-235-5-208.dyn.iinet.net.au. [220.235.5.208]) by smtp.gmail.com with ESMTPSA id y22sm22829947pfr.163.2021.02.02.11.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Feb 2021 11:55:26 -0800 (PST) References: <874kr6402z.fsf@gmail.com> <87y2o11ef5.fsf@gmail.com> <87eeptfe4u.fsf@gmail.com> User-agent: mu4e 1.5.8; emacs 27.1.91 From: Tim Cross To: Christopher Miles Subject: Re: patch: ob-clojure improvements Date: Wed, 03 Feb 2021 06:52:35 +1100 In-reply-to: Message-ID: <87tuqu1bys.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=theophilusx@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "emacs-orgmode@gnu.org" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.06 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=AHALZAdH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 934079404FA X-Spam-Score: -3.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: tioZEVLHRyfb OK, will push it up the todo list. Where can I get the latest version of the patch or has it been added into the org git repo? Christopher Miles writes: > <#secure method=3Dpgpmime mode=3Dsign> > > Hi, Tim, popup this thread to request review. =F0=9F=98=84 > > Tim Cross writes: > > I am also interested in ob-clojure and ob-clojurescript improvements. How= ever, right now, I'm a tad busy and haven't had time to review what has bee= n done. Hopefully, can make some time in the next month or so. > > Tim > > stardiviner writes: > > agzam.ibragimov@gmail.com writes: > > There seems to be a bit of lack of interest for these things. But I'm sur= e some people (myself included) would love to see these kinds of improvemen= ts. > > Yes, I rarely saw Clojurians in this mailing list. > > As I said before, I have never participated in contributing to Org source= , some guidance would be appreciated. > > Org Mode has contribution guide here http://orgmode.org/worg/org-contribu= te.html#patches > > Should I keep building it and posting patches? Should I try to go increme= ntally, one small change at a time, or should I just get everything working= first? If it turns out to be a bigger work, should I ask for permission to= work in a branch and get access to pushing things to it? Maybe things just= move slowly, because obviously you can't force maintainers to drop everyth= ing and concentrate effort to get your things in. Maybe I just have to be a= little bit more patient? > > I think a complete work contains many patches should be better, Also writ= e testing if necessary. > > I remember ob-clojure.el code are mostly reviewed by Bastien Guerry. I in= cluded him in Cc: in this email. > > On Sat, Jun 20, 2020 at 1:23 AM stardiviner wrote: > > Glad to see your patch, really useful in some cases. Thanks. > > Ag Ibragimov writes: > > Hi everyone, here's my attempt to add clojure CLI and babashka support > for ob-clojure.el > - Adds a header parameter to override org-babel-clojure-backend - Adds :a= rgs param (right now only used for clojure-cli) > > I have tested it with these minimal cases: > > #+beginsrc clojure :backend clj-cli :args "-Sdeps '{:deps {inflections > {:mvn/version \"0.13.2\"}}}'" > (use 'inflections.core) (plural "word") #+endsrc > > #+beginsrc clojure :backend babashka :results output (range 10) #+endsrc > > Please let me know what you think. Any advice is appreciated, since I > have never contributed before. Thank you. > > =E2=80=93 [ stardiviner ] I try to make every word tell the meaning that = I want to express. > > Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: = stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 -- Tim Cross