From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp11.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms5.migadu.com with LMTPS
	id 2GnSIoY9zGKLIgEAbAwnHQ
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Mon, 11 Jul 2022 17:11:02 +0200
Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp11.migadu.com with LMTPS
	id YPu9IoY9zGI4GQEA9RJhRA
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Mon, 11 Jul 2022 17:11:02 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 1E79CCFF6
	for <larch@yhetil.org>; Mon, 11 Jul 2022 17:11:02 +0200 (CEST)
Received: from localhost ([::1]:43114 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	id 1oAv3s-0007yC-Sa
	for larch@yhetil.org; Mon, 11 Jul 2022 11:11:00 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:45414)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <gusbrs.2016@gmail.com>)
 id 1oAu2y-0000hF-E4
 for emacs-orgmode@gnu.org; Mon, 11 Jul 2022 10:06:00 -0400
Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]:33570)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <gusbrs.2016@gmail.com>)
 id 1oAu2w-0005yE-9J
 for emacs-orgmode@gnu.org; Mon, 11 Jul 2022 10:05:59 -0400
Received: by mail-qk1-x731.google.com with SMTP id f14so3894010qkm.0
 for <emacs-orgmode@gnu.org>; Mon, 11 Jul 2022 07:05:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=sender:references:user-agent:from:to:subject:date:in-reply-to
 :message-id:mime-version;
 bh=baaO5buVzFdsExnLbI5K2K4HGmsGJ0G8sWJHQL2e4lw=;
 b=p6biIbXH8WBE6mH1Sn/fNm/9/A6QO4oALCh5Z6fU0RrOX89r3ur5R/wr/dG9ZVTRwP
 hpWHK51MbB0XjuJ/324yyYG+uGbdPVegypw6Ib/bdC8iy0mNDvzvzYdVn7UR+iL8WN3g
 B47j+M+xUEVhbdGc0yzVcLj2MtRXFHMHLI5uAUeHFvq4+qRM+pC9iEWyfPx3AYOMiBO2
 YY4vJq22P9Er++pnhZGjMwZoEIAZH/Aa7ppgQ5xzl4c9YhkiV5hEGZlvz+ARkkyB9FWm
 equC5rXqMR4S2vqerjS+9mFJOsRqAPL8ovqpBtx+UZroQhmUWQo5ae8Wl7UxZbWvmEco
 FXlw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:sender:references:user-agent:from:to:subject
 :date:in-reply-to:message-id:mime-version;
 bh=baaO5buVzFdsExnLbI5K2K4HGmsGJ0G8sWJHQL2e4lw=;
 b=LI/xdqvpk0pi2BW9+Af6VYKkM8ThsD9PdzEkiWu/5tnk0ZAN8paTQ/CgfcsyqMwUAz
 N0IBnyS5mtzxkvJrM+rPF8onK54gbtPbE9B9EwBqRpRD99C6akfY0ubj6ctxgHDe+CQb
 8V2Z0Tt0gttVpj7m0D8sK5p1oK8uHFbio2rpfU6sVRL8YryH/31Kw6R4VUNcMMzjSUjF
 UUWhuIENIkrxxftUdYVYboqFzn3GIl1XRW5taaOI1SNZisYlnPutUvOpEC+AjbP3Y3zs
 ECBrTn9cPydxBcAPDg0IfffUFKGvbosjKNc76bV0EMahDHW4tB5D7XJi/DfRZssBQpCY
 /wZw==
X-Gm-Message-State: AJIora+Kz8ZnyHgdlBju5oy92OCBQHonoebLiNjaPUgKceqPys4+zSTB
 2GcBfWZYkQD2h5wgLkKWibZiWFAfvxw=
X-Google-Smtp-Source: AGRyM1s+/B50xzN0iWzmLtDj1viF9Seq4IcwdCBP3PgbVmpafdTA2zl/YKU/B4I4RboQm/OGeg6GyA==
X-Received: by 2002:a37:e205:0:b0:6b5:7ab7:e7de with SMTP id
 g5-20020a37e205000000b006b57ab7e7demr5224825qki.458.1657548355949; 
 Mon, 11 Jul 2022 07:05:55 -0700 (PDT)
Received: from gusbrs-laptop ([191.96.67.189])
 by smtp.gmail.com with ESMTPSA id
 cc22-20020a05622a411600b0031ebb1f8918sm169209qtb.76.2022.07.11.07.05.54
 for <emacs-orgmode@gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Mon, 11 Jul 2022 07:05:55 -0700 (PDT)
References: <87ee84dllb.fsf@gmail.com> <87k0hwdk54.fsf@localhost>
User-agent: mu4e 1.8.5; emacs 28.1
From: Gustavo Barros <gusbrs.2016@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [BUG] Future repeated tasks marked done in Org Agenda don't
 show as done [9.5 (9.5-g0a86ad @ /home/gustavo/.emacs.d/elpa/org-9.5/)]
Date: Mon, 11 Jul 2022 10:51:55 -0300
In-reply-to: <87k0hwdk54.fsf@localhost>
Message-ID: <87tu7n68xs.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Received-SPF: pass client-ip=2607:f8b0:4864:20::731;
 envelope-from=gusbrs.2016@gmail.com; helo=mail-qk1-x731.google.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: "Emacs-orgmode" <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
X-Migadu-To: larch@yhetil.org
X-Migadu-Country: US
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1657552262;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=baaO5buVzFdsExnLbI5K2K4HGmsGJ0G8sWJHQL2e4lw=;
	b=Nfp4OF9ytzAoVMuGyvF6iEUnCg2F5BoKarpyNK8Io31sz7LOlV2oQsvpTDSDM2wy1oZ1Qe
	JueJrVY9KhwpUp4n4W1y7RWQnIANL+4s5GqGnCVP18WzPJq1yGjyVmmpWN3X1Jytw1NAsq
	59M+/vaFnTHXY78zC6jRAoeWHpyLV29oZTVGWw37xMoT4YwVFiA8QrJGg/YXZIOOgufZwy
	PbCY9dV7cvJZ7oy0L7260ffULoJwEhd6qDTawbQQG6g/KMTFGQ7ifufwrrCansAs98jiQj
	kL95b6AN2D7nDqoVZLANPY+yaFt+M2HvC9VDACvcqLacB9ROiXFW3FaZHYP9Mg==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1657552262; a=rsa-sha256; cv=none;
	b=PH6qY+FmajxFh+4aQ5QF3rYtJtQRiFQQNZpkM1j2z1bP2Cv8ip8yzie3dc4O3ClVgwI+YM
	XHo7osTrhEnqZ8IAwohfATupYPWW1xsNJIqSQkHuaG/htMSNHGzHJuCMn3ZDaSRyLkP+kP
	KyH2QlvfUzsVgZRSF22Sy2rGsqRHDTU5ZPykYl9YxjUJYr6MmLrcGKB1J75Pyjv2O342iw
	Qt9aLPSbZOo92wch5Ct6lAMN46Hxjw2IVXn2Xuu3qp69QcxpYEo8BU65btmQIyAHZWzAU8
	qWNKWCIE3OPzwgOLKAdE9CZs1Unmt93VMgfST7eAIztP8HObH4AKTwPJyzOjiA==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=p6biIbXH;
	dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none);
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Spam-Score: 5.15
Authentication-Results: aspmx1.migadu.com;
	dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=p6biIbXH;
	dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none);
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
X-Migadu-Queue-Id: 1E79CCFF6
X-Spam-Score: 5.15
X-Migadu-Scanner: scn0.migadu.com
X-TUID: 82Ve5D6oaO/m

Hi All,

On Fri, 29 Oct 2021 at 21:40, Ihor Radchenko <yantar92@gmail.com> wrote:

> Gustavo Barros <gusbrs.2016@gmail.com> writes:
>
>> The glitch is that some repeated tasks, when marked done in the 
>> Agenda, 
>> show no visual feedback that the action has taken place, as usual, 
>> and 
>> if you refresh the Agenda, they just vanish, which demonstrates the 
>> action had indeed taken place in the agenda file, just not shown in 
>> the 
>> Agenda buffer itself.  And, as far as I can tell, this happens to 
>> repeated tasks, scheduled in future.  For tasks scheduled for today 
>> or 
>> in the past, they appear to be done as expected.
>
> Confirmed
>
> Best,
> Ihor

This is a respectful bump on this one.

But not to bump empty handed, I did some investigation on this, and I 
think I know why the problem happens.

At `org-agenda-todo' when a task is a repeating one, the value of 
`org-agenda-headline-snapshot-before-repeat' stored at `org-todo' may or 
may not replace `newhead' depending on some conditions, which are:

#+begin_src emacs-lisp
(when (and org-agenda-headline-snapshot-before-repeat
	   (not (equal org-agenda-headline-snapshot-before-repeat
		       newhead))
	   todayp)
  (setq newhead org-agenda-headline-snapshot-before-repeat
	just-one t))
#+end_src

So that `newhead' is set to `org-agenda-headline-snapshot-before-repeat' 
only if `todayp' is non-nil.  And, indeed, this seems to be the 
condition which results in the missing visual feedback reported here. 
I've tried without it, and it works.  (I'm currently using built-in 
9.5.2, but I think there's no change in the function to current release 
9.5.4 and also, light testing with the latter suggests no change in the 
reported issue).

What I'm not sure is why this condition is there in the first place. 
That's the only place where the let-bound `todayp' is used in the 
function, so I may be missing why it exists and the purpose of this 
condition.  But one side-effect of it is that, if you happen to do a 
repeating task ahead of schedule, you won't see the change of todo state 
in the agenda.

Best regards,
Gustavo.