From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OvHiFSWfcGMUTgEAbAwnHQ (envelope-from ) for ; Sun, 13 Nov 2022 08:39:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yKTsFCWfcGMLPAAAauVa8A (envelope-from ) for ; Sun, 13 Nov 2022 08:39:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0169A3AED4 for ; Sun, 13 Nov 2022 08:39:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ou7ZS-0001m5-MW; Sun, 13 Nov 2022 02:38:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ou7ZM-0001lm-At for emacs-orgmode@gnu.org; Sun, 13 Nov 2022 02:38:20 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ou7ZF-0005eO-F8 for emacs-orgmode@gnu.org; Sun, 13 Nov 2022 02:38:15 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8D0D2240026 for ; Sun, 13 Nov 2022 08:38:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668325091; bh=8z7ncxgDqT5N9+H35a0uJsIkVXqupN40hpvbCSmqa+g=; h=From:To:Cc:Subject:Date:From; b=Ynj07Tg5urQ9KEmm8LbuJipDn/kOzvM1HgmDibC0/gKqV8XCROtP9ONQIboyXe9VC c4nZhbNTa7ClBa1Fl47sr0E2iOXlGlTVSdlHDNI2LINhhJaxbxwkgAWiPjrDBHiwrG iFvcle0hd8wadrulWOb2LdlMxgY75RwstrpDeHgMp2U6ATlLI+g05JAdh8Lo5rQ+DL oagG2grAVF71UABIQYTqqqaUJ8Q3i1A3sybUf2Y/h0Gma4dkXYMQ0YIVccdfadY9Zm NWHemq9FAGecQPY5BLIi6qnkcjCK3i/bQRz9YO9kUPKtUOV4sd/Q2NU3nvFrsNlwuY MOTBWcjqU+VNg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N946p0kvXz9rxF; Sun, 13 Nov 2022 08:38:09 +0100 (CET) From: Ihor Radchenko To: Timothy , Bastien Cc: Stefan Kangas , Ihor Radchenko , Daniel Mendler , emacs-orgmode@gnu.org Subject: [PATCH] Re: [STYLE] :version tags in defcustom definitions (was: [PATCH] Improve look of agenda on graphical displays) In-Reply-To: <87sfnn7e8x.fsf@gmail.com> References: <8735fnltc1.fsf@localhost> <87fsjnk575.fsf@localhost> <87sfnn7e8x.fsf@gmail.com> Date: Sun, 13 Nov 2022 07:38:51 +0000 Message-ID: <87tu337184.fsf@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668325157; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4rcYdun3Rnd04N2OQHpCO4YOJYFJ8jo5YnlCna1wI80=; b=nv3ItGPWJPworm5wh3YlKxgtlIwuQk16wmlpy0sfAOOZfHQKkzMNQoEXOqAmIZlIWm9uw0 XBeSNW4KT0x6PIdHuyTcmoIu4qM+4UotIifgWh18KmAVNZz+JkEbcvL4of3VY4fjvCX4NE N6q2zKdPrXPG4Tn1nn9CBZy+LcRdsNdpiPNFTLh3LsTb23bhn1zyjGUOZ046fehfl01R8u Q4rVyBwJC49OrwwGXZFXItGiA5B4kT5S+TDaUzmAQkxWt2+2qmz5Yaq9BQLZ4F2lZis5k3 jBWwRvJaWQAEE5r8pNaQY9Mrd06fHwVRPDNwkpDnXFn+ta0f4tNy4AuXWcTw2A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668325157; a=rsa-sha256; cv=none; b=SQ5gukTWP54/y65LAvFvs3F4HP13MHo9T/YaXmO1n5l3BiX9uBpoQh09bmkbeIqn6sWDnQ 5DYNNBiy358+5bQd7t7XMAeH/i4dhePBIVKxQliuHVfkPIi1Xl9OUR25px05Z8hrWJsyQE XVpq6+euphRRzbB/UZn5ctzNLiAIwwC27gqwlUYV2oT4XPEz/VzzBPWqoSauMX/vCsM1+G YRMX0fBDT0zioPcKVfuSxgDNadWL2vBNlbOetziG/B5Uv8LD9E+bLggL/CrYrp1342LDom AEXLLlkUTs5aXI0WML9TfUF4LwOj0f4t7sPv519HOdnbjGiStcFcnaXtqVRiTA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Ynj07Tg5; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.35 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Ynj07Tg5; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 0169A3AED4 X-Spam-Score: -3.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: hVL/8yeYz0p2 --=-=-= Content-Type: text/plain Timothy writes: >>> Sure. Just trying to clarify my confusion. The inconsistency with some >>> defcustoms using :version and some not is bugging me. >> >> Agreed. It would be better to be consistent with this. > > Given that org-mode is distributed separately to Emacs, and I get the impression > having a newer org-mode version that Emacs version is not uncommon, I think it > would make sense to have /just/ org-mode version tags. I have just updated the :package-version tags in the new and changed variables in Org 9.6. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5a10517d021acba071cd4a2c3b90de84c8e9f3cb I also plan to push the attached change to org-maintenance document in WORG. I think we can replace the old :package keywords as needed, similar to the Emacs' whitespace policy. Let me know if there are any objections. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-org-maintenance.org-Document-updating-package-versio.patch >From f1e2b8daca3bb4bdde0d6d98376d2f1e4c608e94 Mon Sep 17 00:00:00 2001 Message-Id: From: Ihor Radchenko Date: Sun, 13 Nov 2022 15:33:50 +0800 Subject: [PATCH] org-maintenance.org: Document updating :package-version * org-maintenance.org (For minor and major releases): Document that it is necessary to update :package-version in the new and changed `defcustom' statements. --- org-maintenance.org | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/org-maintenance.org b/org-maintenance.org index 3cc1ea53..35b70e0a 100644 --- a/org-maintenance.org +++ b/org-maintenance.org @@ -274,6 +274,10 @@ *** For minor and major releases When doing a minor or major release, the =main= branch should be merged into the =bugfix= branch. +Also, ~:package-version~ tags should be added to new and changed +~defcustom~ statements as needed. If a statement also contain ~:version~ +tag, it should be removed in favor of ~:package-version~. + *** Releasing by adding a new tag :PROPERTIES: :CUSTOM_ID: release-tags -- 2.35.1 --=-=-= Content-Type: text/plain -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at --=-=-=--