From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id II/4Aox5gWM9dQEAbAwnHQ (envelope-from ) for ; Sat, 26 Nov 2022 03:27:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id t30fAox5gWMMnQAAG6o9tA (envelope-from ) for ; Sat, 26 Nov 2022 03:27:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 97FF43AEA2 for ; Sat, 26 Nov 2022 03:27:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyktX-0008Qh-P0; Fri, 25 Nov 2022 21:26:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyktW-0008QJ-E1 for emacs-orgmode@gnu.org; Fri, 25 Nov 2022 21:26:18 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyktR-00054Z-Mq for emacs-orgmode@gnu.org; Fri, 25 Nov 2022 21:26:18 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id BE754240101 for ; Sat, 26 Nov 2022 03:26:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669429571; bh=86o3AN3Z+afUyurPYiDupiHmdFrprNDOxUJ32O4zp0U=; h=From:To:Cc:Subject:Date:From; b=LWLKMpbhRhUTgifpzCtusIx9+f51ZGW6ZmImeJybz8b+vZ7KWLoRitAMZQxNZNZG9 UJKZ9yHTrWxUKUKq/Mdqknjwk+Fn+noPmOizrayltg+zN2E86zwkz2LXl9WLga5lkN 11icwVzIdty7BEfl+wg7QQ3mxhDLoGAhI24EdivATDXWi1kCMo5f0DlwEbWgrviLLb z3IhNDdz7Pcv0xNxlcbpOhZo2GQ/KfzGH1uZnlGeUofzf0y1giCNDyhTmNmJy3B12S br1kAA2d5o8Q28RevubLreTMYA9Be8XEGovgBuK98KIty9AH/g4iD+DZBUcfYfWWtA v/z7DpG91XX8g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NJwZl57qLz9rxK; Sat, 26 Nov 2022 03:26:07 +0100 (CET) From: Ihor Radchenko To: yuvallangerontheroad Cc: "emacs-orgmode@gnu.org" Subject: Re: [PATCH] Explain how to end a buffer narrowing. In-Reply-To: References: <87cz9b9kau.fsf@localhost> <877czj9jd2.fsf@localhost> Date: Sat, 26 Nov 2022 02:26:41 +0000 Message-ID: <87tu2mlace.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669429643; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=l3WC0jjpnGXdWQqVcTVXwLM0fK0unxi3QaICF0EUuB0=; b=hjMiFUbGFZIu7j7Mh2mA2MyixF4RVp11vOAjq8t/nYnmgBhV2egHJ4mBxL3J/4fL0rChwH H5lJSGy8Lk/KMNF+vBhhsMHuNSChJRpnhmZpWLMhRCLurFp9+BN9xZpFY57kI+zb6lVkZD GC7EerVWyzu+Nf9HqdtrctKaBW4eHRfJRIUhqZljGs8qHoN2EXn5YS66Y+wVU9lcNk/Mp5 KPBNNzb2suk/PQBaZeZF7FMbGtc2wnQhQgV4j/jsnhtuqcKp3sJlvr1EW5xeem/5wzmU9t +okMj8UrpQays0qhF1KLlXGIxHk4Mf6y3IN1GhRT2UyYLnDNn0HxNChoku0xAQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669429643; a=rsa-sha256; cv=none; b=pAaCu6xyEMEXROYLDozAylle9qFUitGZgNWPCZpi/rR0UwEme1/1jqVSkHcAwp2wwfXh/o anAlH/qsgH8pZCd0nbZka30OrnrRXC3Ci47en/gYKvgSf9aLtO7NZ4vgQvYlah/GIFHVMe +QRxKiWNCBUYAIL6CXHjpx6hiD0kGmiS8Ey/f4h/5hHHnSgGLaVmq3taJpCqQl0k+Rz34R fZEU82rPeSM8jZ7nG/lJBpptHYnoCLWO7tTMoF9LXDUfwAqt1ZIn2k9yl8Z95Lj3TbMpFT x8M09XNb+J8U3/Ay8bYrXedaL0l7fhDApmTOcM0pt2sVWkIS6hHaGvAoGG7eeQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=LWLKMpbh; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.07 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=LWLKMpbh; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 97FF43AEA2 X-Spam-Score: -2.07 X-Migadu-Scanner: scn1.migadu.com X-TUID: svBVrIJNRv4n yuvallangerontheroad writes: >> Extra [...] are redundant. >> Please test the patch before submitting. > > Sorry. Removed redundant brackets. Thanks. It is also a good idea to add quotes around the command key. See the example in 25.3 Substituting Key Bindings in Documentation (I am honestly not sure how important quoting is, but let's better follow the Elisp manual). Also, please make the commit message more concrete. Maybe something like org: Mention how to widen in docstrings of the commands that do narrowing Finally, please follow the commit message format as described in https://orgmode.org/worg/org-contribute.html#commit-messages In particular, add the changelog entries and TINYCHANGE cookie (I assume that you don't have FSF copyright assignment). -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at