From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QP6IMyqApmXoOAEA62LTzQ:P1 (envelope-from ) for ; Tue, 16 Jan 2024 14:10:02 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id QP6IMyqApmXoOAEA62LTzQ (envelope-from ) for ; Tue, 16 Jan 2024 14:10:02 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=mXwwhIBH; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705410602; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WjBsVeEQKfSrkpcEshUSGK2zbXX6ZzgzheLUA3cVsLA=; b=CtGxokta6gEO0DBKUfPrjftJz+VfTTDla1VsrI+QDJfnFSD1nF3oNB3IQPfT/6EWP/yYsI Nzqm5OIfhpDuVFhv3vo0236KM2EMdpW00028XpZtMXF5HPgn8/dUs+2a42XknvcgqGw6S9 4dM/dHiqZ8pkFQfX+eNTMn7oXo9nH7T5fQF4oXiU1dW5xHci+cywqxSPUZSY9g2AoPi684 DcudjsIlsERSL0WUXpXiUFFWjLMqpRvDrRl68ajMEncWbDKHk3alAtwDcNXFAsK+4XaiQ8 QC2xrldeZFqOloS/b+df2sHhtKlyHXh0nxtD0fQ1SgqHtXojo1D6lZjQrHJICg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=mXwwhIBH; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705410602; a=rsa-sha256; cv=none; b=GxQeVpceH4eokjPMyD9IrdSFN9WCXfuaY2r+GXJLyLRs1OqluGbabs26OKQKYWPiXHNEFE MKdiP+1dzbdsENhkg9NRUaKNiXMKDUwqodcUr6a6chk7qsFTcgFFpzJlOHZp63f2Bd9X99 rxoB17c1MckQSkqgrkAkG4+y1K0LapUg6vmHm3tvVboR91y1pqNoNfWlT/oEVHXcw8jN44 ml9keoV9oV4AtDk0nsLJpZEfW7eFBqnbIaOCKtNy17UjZgJQ43gT/XOxeW5PbZ3gpBmox7 Vgz70bFnOtHZmJWMCcFx/gU4lYA1Qc7+fKZQMs4sLtZC5yKE2GIVqSp5dqSHug== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7BD8536D8B for ; Tue, 16 Jan 2024 14:10:02 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rPjBp-0006Gg-VD; Tue, 16 Jan 2024 08:09:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPjBn-0006Fy-2F for emacs-orgmode@gnu.org; Tue, 16 Jan 2024 08:09:11 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPjBk-00080M-1d for emacs-orgmode@gnu.org; Tue, 16 Jan 2024 08:09:10 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CA56124002A for ; Tue, 16 Jan 2024 14:09:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1705410543; bh=6Spu2ihMWOZBe+mjiOb+qur3Dnd1mNfJ4/80SWCdjEk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=mXwwhIBHU8bCZ7I6wRh354T9479ZUm3g2zK58Er2FtXeYIlVZ90c+u6HbvTtNeTXd ngVTQAsF3QL/h3yh4ni+eKu/CY/1rzBmogZg1cgdhV/8DgsxukQt8SfnM5lp56Ce2j jDeYMbYUmPa3/rNGtEyCWfurG54H/hDoH5T8m2JkqXTIPYHTN7ZAy17e66C4rjMf3V C/eI2XZwf8IApNUhkZEKMnAYdZvgJJnPrBGIwvzC2xX6QyiN+ibxvtrWc/cZhV5dmo eKywUtPm+gmlpAzTknw2dMAxb7DkuvbAVhWW9y6kG/J6Eo16Yvi8Bl+7sSTVdnzxTk XpyMafastNwGQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TDq8Z4zKZz9rxL; Tue, 16 Jan 2024 14:09:02 +0100 (CET) From: Ihor Radchenko To: Matt Cc: emacs-orgmode Subject: Re: [PATCH] ob-shell: consistent prefix In-Reply-To: <18d0ef7e532.10851f5ed1771823.3915352479016848501@excalamus.com> References: <18d0ef7e532.10851f5ed1771823.3915352479016848501@excalamus.com> Date: Tue, 16 Jan 2024 13:12:11 +0000 Message-ID: <87ttndl8wk.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.67 X-Spam-Score: -8.67 X-Migadu-Queue-Id: 7BD8536D8B X-Migadu-Scanner: mx12.migadu.com X-TUID: f/FThuZKmrzl Matt writes: > The attached patch makes names in ob-shell.el use the same prefix > "org-babel-shell-" (along with a few similar minor consistency > updates). > > Without the patch, three naming conventions exist: > > - org-babel-shell > - org-babel-sh > - ob-shell <----- that's my fault :) > ... > The current "sh" names are generic and not specific to "/bin/sh" or > something like the Bourne Shell. The patch updates all "sh" names > to "shell". I do not mind changing the names, except that we must not break backwards compatibility. In particular, the non-private function and variable names that were present in the latest Org stable release must be either supplied with an alias or declared obsolete. Otherwise, the third-party code using the old names will be broken. It is ok to change the variable names when the variables are introduced within current main branch and not yet released. Further, some function names are not arbitrary, but are instead dictated by the rules ob-core.el demands from the babel backends. The following variable and function names are special and must be named specifically by babel backends: - org-babel-default-header-args: - org-babel-execute: - org-babel-expand-body: - org-babel-variable-assignments: - org-babel-header-args: - org-babel-load-session: - org-babel--initiate-session - org-babel-prep-session: - org-babel-edit-prep: - org-babel--associate-session > -(defun org-babel-variable-assignments:shell (params) > +(defun org-babel-shell-variable-assignments:shell (params) This will break ob-shell as we change the expected function name from the above list. > -(defun org-babel-sh-initiate-session (&optional session _params) > +(defun org-babel-shell-initiate-session (&optional session _params) In theory, this should still work because `org-babel-shell-initialize' create aliases to define multiple babel backends, for each shell name in `org-babel-shell-names'. However, no alias is created for `org-babel--initiate-session' in particular, which is probably a bug. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at