[PATCH] org-show-notification will use todochiku.el if available

[PATCH] org-show-notification will use todochiku.el if available

[Jason F. McBrayer]

This is a little patch to let org-show-notification (in org-clock.el)
use the package [todochiku.el] if available.  This means that if
todochiku has been set up correctly, org-show-notification will work
with Growl (on MacOS) or Snarl (on MSWindows), as well as libnotify (on
*ix). 

[todochiku.el] http://www.emacswiki.org/emacs-se/ToDoChiKu
---
 lisp/org-clock.el |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 594d3cf..5428aa1 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -440,9 +440,12 @@ Notification is shown only once."
 	(setq org-clock-notification-was-shown nil)))))
 
 (defun org-show-notification (notification)
-  "Show notification. Use libnotify, if available."
-  (if (org-program-exists "notify-send")
-      (start-process "emacs-timer-notification" nil "notify-send" notification))
+  "Show notification. Use todochiku.el or libnotify, if available."
+  (if (fboundp 'todochiku-message)
+      (todochiku-message "org-mode notification" notification
+                         (todochiku-icon 'emacs))
+    (if (org-program-exists "notify-send")
+        (start-process "emacs-timer-notification" nil "notify-send" notification)))
   ;; In any case, show in message area
   (message notification))
 
-- 
1.6.1.2


-- 
+-----------------------------------------------------------+  
| Jason F. McBrayer                    jmcbray@carcosa.net  |  
| If someone conquers a thousand times a thousand others in |  
| battle, and someone else conquers himself, the latter one |  
| is the greatest of all conquerors.  --- The Dhammapada    |  

Re: [PATCH] org-show-notification will use todochiku.el if available

[Bastien]

Hi Jason,

thanks a lot for the idea.  I have generalized this approach a bit by
adding a new option: org-show-notification-handler.  

The value of this new variable can either be an elisp function or a
program.  The function/program will be called with the notification 
string as an argument.

So for example:

(setq org-show-notification-handler
      '(lambda (notification)
	 (todochiku-message "org-mode notification" notification
			    (todochiku-icon 'emacs))))

should do what you want.

If this variable is nil, the notification mechanism falls back on
notify-send (if available) and the elisp message otherwise.

Thanks again!

-- 
 Bastien

Re: [PATCH] org-show-notification will use todochiku.el if available

[Jason F. McBrayer]

Bastien <bastienguerry@googlemail.com> writes:

> thanks a lot for the idea.  I have generalized this approach a bit by
> adding a new option: org-show-notification-handler.  

That certainly does the job.  For me it means configuring notification
method in two places (org and todochiku), but that's not unreasonable,
given that not very many people will have todochiku installed.  Thanks
for including the feature if not the patch.

-- 
+-----------------------------------------------------------+  
| Jason F. McBrayer                    jmcbray@carcosa.net  |  
| If someone conquers a thousand times a thousand others in |  
| battle, and someone else conquers himself, the latter one |  
| is the greatest of all conquerors.  --- The Dhammapada    |