From: Julien Danjou <julien@danjou.info>
To: Matt Lundin <mdl@imapmail.org>
Cc: Bastien Guerry <bzg@altern.org>, emacs-orgmode@gnu.org
Subject: Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)]
Date: Mon, 07 Feb 2011 12:39:17 +0100 [thread overview]
Message-ID: <87sjvzaezr.fsf@keller.adm.naquadah.org> (raw)
In-Reply-To: 87wrlfl1jx.fsf@fastmail.fm
[-- Attachment #1.1.1: Type: text/plain, Size: 403 bytes --]
On Sat, Feb 05 2011, Matt Lundin wrote:
> This results in only a day view because org-agenda-current-span is still
> 'day.
Here's a proposal fix.
I could have setq org-agenda-current-span to nil as a work around, but
it seems more logical to just kill all the local variables. That is, a
custom agenda view would not keep any of the local variable of the
previous agenda, which seems logical to me.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: 0001-org-agenda-kill-local-variables-in-agenda-view.patch --]
[-- Type: text/x-diff, Size: 1136 bytes --]
From b48fc7c395dffea60df20c23b26e362ac0354b01 Mon Sep 17 00:00:00 2001
From: Julien Danjou <julien@danjou.info>
Date: Mon, 7 Feb 2011 12:36:42 +0100
Subject: [PATCH] org-agenda: kill local variables in agenda view
* org-agenda.el (org-agenda): Kill all local variables. This
assures we are not keeping buffer variable from an old agenda view
when switching to a new custom agenda.
Signed-off-by: Julien Danjou <julien@danjou.info>
---
lisp/org-agenda.el | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index d146f83..9a3d953 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -2161,6 +2161,8 @@ Pressing `<' twice means to restrict to the current subtree or region
(put 'org-agenda-redo-command 'org-lprops nil)
;; Remember where this call originated
(setq org-agenda-last-dispatch-buffer (current-buffer))
+ ;; Remove all local variables
+ (kill-all-local-variables)
(unless keys
(setq ans (org-agenda-get-restriction-and-command prefix-descriptions)
keys (car ans)
--
1.7.2.3
[-- Attachment #1.1.3: Type: text/plain, Size: 53 bytes --]
--
Julien Danjou
❱ http://julien.danjou.info
[-- Attachment #1.2: Type: application/pgp-signature, Size: 835 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2011-02-07 21:11 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 4:09 Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)] Bernt Hansen
2010-12-22 7:03 ` Noorul Islam K M
2010-12-22 12:29 ` Bernt Hansen
2011-01-14 12:34 ` Carsten Dominik
2011-01-14 16:03 ` Bernt Hansen
2011-01-14 17:29 ` Carsten Dominik
2011-01-14 17:42 ` Bernt Hansen
2011-01-17 14:27 ` Bernt Hansen
2011-01-17 14:39 ` Carsten Dominik
2011-01-17 15:08 ` Julien Danjou
2011-01-17 16:34 ` Julien Danjou
2011-01-17 16:43 ` Carsten Dominik
2011-01-17 16:46 ` Julien Danjou
2011-01-18 9:43 ` Carsten Dominik
2011-01-18 10:00 ` Julien Danjou
2011-01-18 10:15 ` Carsten Dominik
2011-01-17 16:47 ` Bernt Hansen
2011-01-17 16:54 ` Julien Danjou
2011-01-17 17:00 ` Bernt Hansen
2011-01-17 17:04 ` Julien Danjou
2011-01-17 17:01 ` Carsten Dominik
2011-01-17 17:11 ` Julien Danjou
2011-01-17 17:14 ` Bernt Hansen
2011-01-17 18:27 ` [Accepted] " Bastien Guerry
2011-01-28 15:18 ` Julien Danjou
2011-01-28 15:43 ` Giovanni Ridolfi
2011-01-28 16:10 ` Julien Danjou
2011-02-01 11:52 ` Bastien
2011-02-01 11:52 ` [Accepted] " Bastien Guerry
2011-02-05 1:20 ` Matt Lundin
2011-02-05 8:56 ` Julien Danjou
2011-02-07 11:39 ` Julien Danjou [this message]
2011-02-08 17:05 ` [Accepted] " Bastien Guerry
2011-02-09 16:37 ` Bastien
2011-02-10 9:20 ` Carsten Dominik
2011-02-10 10:51 ` Julien Danjou
2011-02-10 11:50 ` Carsten Dominik
2011-02-10 12:00 ` Julien Danjou
2011-02-10 14:35 ` Bastien
2011-02-10 21:21 ` Michael Brand
2011-02-17 13:57 ` Carsten Dominik
2011-02-17 14:43 ` Bastien
2011-02-18 14:19 ` Bastien
2011-02-18 14:46 ` Gábor Melis
2011-02-18 16:42 ` Carsten Dominik
2011-02-19 9:36 ` Bastien
2011-02-10 11:18 ` Michael Brand
2011-02-10 11:55 ` Carsten Dominik
2011-02-24 14:38 ` Matt Lundin
2011-02-24 15:01 ` Matt Lundin
2011-02-25 0:11 ` Bastien
2011-02-25 0:15 ` Bastien
2011-03-06 15:40 ` Bastien
2011-03-06 16:47 ` Michael Brand
2011-03-06 17:15 ` Bastien
2011-03-06 18:26 ` Michael Brand
2011-03-06 18:35 ` Bastien
2011-03-07 18:26 ` Matt Lundin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjvzaezr.fsf@keller.adm.naquadah.org \
--to=julien@danjou.info \
--cc=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
--cc=mdl@imapmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).