From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: patch makefile solve a couple debian build problems and a slackware build problem Date: Sun, 10 Jul 2011 12:07:32 +0200 Message-ID: <87sjqejvob.fsf@Rainer.invalid> References: <87k4bqwkyw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([140.186.70.92]:42575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfqvZ-0001gf-Dp for emacs-orgmode@gnu.org; Sun, 10 Jul 2011 06:07:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QfqvX-0001CJ-DZ for emacs-orgmode@gnu.org; Sun, 10 Jul 2011 06:07:53 -0400 Received: from lo.gmane.org ([80.91.229.12]:43883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfqvX-0001CF-1s for emacs-orgmode@gnu.org; Sun, 10 Jul 2011 06:07:51 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QfqvV-0007Eb-Ei for emacs-orgmode@gnu.org; Sun, 10 Jul 2011 12:07:49 +0200 Received: from p57aab2ac.dip.t-dialin.net ([87.170.178.172]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 10 Jul 2011 12:07:49 +0200 Received: from Stromeko by p57aab2ac.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 10 Jul 2011 12:07:49 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Bastien writes: > Achim and Nick, can I safely apply your patch or was it still a beta > version? My patch obsolotes what Nick was trying to achieve, but I'm just looking at some other stuff in the Makefile that looks like it needs a makeover, so I'd suggest we discuss this first and I'll submit a proper patch that goes into patchwork. Here it goes: It looks like the two targets relase and fixrelease have not actually been used and at least fixrelease would not do what the comment is trying to imply it should be doing. If nobody uses them, these two targets should probably be removed. Then there's all the stuff that "makes sense only on the orgmode server, do not run on your computer": if so, would it not be preferrable to fail these targets when not run on the orgmode server, either by checking an environment variable or a file that only exists on the server? Is there any reason why the phony targets are not declared to be phony? Even if GNU make is not used that should be compatible. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds