From: Bastien <bzg@gnu.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [Bug] Regression w/ insert into tables in overwrite-mode
Date: Tue, 27 Mar 2012 23:53:19 +0200 [thread overview]
Message-ID: <87sjgtogmo.fsf@gnu.org> (raw)
In-Reply-To: <87ehtghyb1.fsf@Rainer.invalid> (Achim Gratz's message of "Mon, 27 Feb 2012 20:27:14 +0100")
Hi Achim,
Achim Gratz <Stromeko@nexgo.de> writes:
> Achim Gratz <Stromeko@nexgo.de> writes:
>
>> Commit 00040e7 by David Maus has introduced a regression when inserting
>> into org tables while overwrite mode is on. For each character inserted
>> into a table cell, the cell (and the whole table row) gets shortened by
>> one character.
>>
>> If the change can not be reverted, the deletion must not
>> happen when overwrite mode is on, maybe through something like this:
>>
>> (if (not overwrite-mode) (delete-char -1))
>
> The change cannot be reverted, since Emacs24 issues a compile-time
> warning about using delete-backward-char, even though that warning has
> been dropped from the doc string... so it needs to be protected or
> replaced by an org-specific version that honors overwrite mode.
I reverted David's change and replaced `delete-backward-char'
by `backward-delete-char', which isn't caught by the compiler*.
`backward-delete-char' is remapped to `delete-backward-char'
by Emacs and `delete-backward-char' is remapped by Org to
`org-delete-backward-char'.
Thanks for your patience on this one!
* This looks weird that an alias isn't caught by the compiler,
I'll let Emacs devs know about this.
--
Bastien
next prev parent reply other threads:[~2012-03-27 23:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 18:59 [Bug] Regression w/ insert into tables in overwrite-mode Achim Gratz
2012-02-27 19:27 ` Achim Gratz
2012-03-27 21:53 ` Bastien [this message]
2012-03-05 19:25 ` Achim Gratz
2012-03-16 18:15 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjgtogmo.fsf@gnu.org \
--to=bzg@gnu.org \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).