From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: [PATCH] Agenda: Fix org-agenda-bulk-toggle when point is at
 already marked item
Date: Fri, 20 Apr 2012 14:55:37 +0200
Message-ID: <87sjfyv9yu.fsf@altern.org>
References: <CAHhKTtEhmD+FGCRwvrs1qD=HiVHjDM=dsrj_eU1cNdPKu=EBJQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:40043)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SLDM8-0007rf-OV
	for emacs-orgmode@gnu.org; Fri, 20 Apr 2012 08:54:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SLDM3-0005UJ-UV
	for emacs-orgmode@gnu.org; Fri, 20 Apr 2012 08:54:32 -0400
Received: from mail-wg0-f41.google.com ([74.125.82.41]:37266)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1SLDM3-0005U1-MB
	for emacs-orgmode@gnu.org; Fri, 20 Apr 2012 08:54:27 -0400
Received: by wgbds1 with SMTP id ds1so642447wgb.0
	for <emacs-orgmode@gnu.org>; Fri, 20 Apr 2012 05:54:25 -0700 (PDT)
In-Reply-To: <CAHhKTtEhmD+FGCRwvrs1qD=HiVHjDM=dsrj_eU1cNdPKu=EBJQ@mail.gmail.com>
	(Madan Ramakrishnan's message of "Sun, 15 Apr 2012 22:29:49 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Madan Ramakrishnan <madanr79@gmail.com>
Cc: emacs-orgmode@gnu.org

Hi Madan,

Madan Ramakrishnan <madanr79@gmail.com> writes:

> * lisp/org-agenda.el (org-agenda-bulk-mark): truly make arg optional
> as advertised by the function

applied, thanks.

> This is my first patch for org so apologies for any inadvertent
> missteps

This is good, but please use plain text emails if possible.

Nick Dokos <nicholas.dokos@hp.com> writes:

> I presume arg can be negative or zero.

A value of arg below 1 doesn't make sense: arg drives the number of 
entries that will be marked, so users usually use this for arg > 1.
If (arg < 1) then the function should trigger an error, which it does.

Best,

-- 
 Bastien