emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Fabrice Popineau <fabrice.popineau@gmail.com>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Display inline images for shortcuts links
Date: Thu, 17 Aug 2017 15:59:26 +0200	[thread overview]
Message-ID: <87shgqpa69.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAFgFV9PffGXUjCcGzXS7Tj2R+O-a9HrKTBEHY9hd5MaBoSx1Og@mail.gmail.com> (Fabrice Popineau's message of "Thu, 17 Aug 2017 14:20:45 +0200")

Hello,

Fabrice Popineau <fabrice.popineau@gmail.com> writes:

> Would it be possible to enable inline images for shortcuts links ?
> Currently, the function `org-display-inline-images' checks for a hard coded
> file: link.
> In the case of :
>
> #+LINK: temp file:c:/temp/%h
>
> [[file:cover.jpg]]
>
> [[temp:cover.jpg]]
>
> The first link will be matched, but not the second one.
> (Unless I missed something?)

Fixed, in master.

> A small patch like the one attached enables to display inline images for
> all links.
> But maybe relying on the org-element API is not the smarter move here.

org-element API is already used in the function (e.g.,
`org-element-property' ...). However `org-element-parse-buffer' is a bit
heavy for the task, in particular in the supposedly common case where
inline image are not the most common link type throughout the buffer.

I simply extended the link search to all link abbrevs, discarding those
that do not ultimately match a file.

Does it solve your issue?

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2017-08-17 13:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-17 12:20 Display inline images for shortcuts links Fabrice Popineau
2017-08-17 13:59 ` Nicolas Goaziou [this message]
2017-08-17 20:05   ` Fabrice Popineau
2017-08-18 10:06     ` Fabrice Popineau
2017-08-18 10:27       ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87shgqpa69.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=fabrice.popineau@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).