emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Possible bug in org-protocol
@ 2019-03-07 22:48 Pierre Téchoueyres
  2019-03-08  8:11 ` Nicolas Goaziou
  0 siblings, 1 reply; 8+ messages in thread
From: Pierre Téchoueyres @ 2019-03-07 22:48 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 2069 bytes --]


Hello Org developers,

I'm facing an unexpected behaviour since some days :
When I want to record some link from web sites using Org Capture extension
(https://github.com/sprig/org-capture-extension) for Firefox all my text
and links are encoded like urls.

It's look like the commit #cc7c4a673 removed some url decoding when
the org-protocol url is processed.

See bellow the steps to reproduce :

1) define some templates for org-protocol, mine are bellow 
#+begin_src elisp
(setq org-capture-templates '(("L" "Protocol Link" entry (file+olp ,inbox "Web")
                                ,(concat "* %:description :@website:\n"
                                         "  Captured On: %a, %U\n"
                                         "  %?\n\n"))
                               ("p" "Protocol Selection" entry (file+olp ,inbox "Web")
                                ,(concat "* %:description :@website:\n"
                                         "  Source:  %a, %U\n"
                                         "  #+begin_quote\n%i\n  #+end_quote\n"
                                         "  %?\n\n"))))
#+end_src

2) use emacsclient to trigger org-protocol like this
#+begin_src sh
emacsclient -n "org-protocol://capture?template=p&url=https%3A%2F%2Fgithub.com%2FCruiserX%2Fsha256_plsql&title=CruiserX%2Fsha256_plsql%3A%20SHA256%20PL%2FSQL%20Implementation%20for%20Oracle%2010g%2C11g.&body=SHA256%20PL%2FSQL%20Implementation%20for%20Oracle%2010g%2C11g.%20"
#+end_src


the resulting buffer is :
#+begin_example
** CruiserX%2Fsha256_plsql%3A%20SHA256%20PL%2FSQL%20Implementation%20for%20Oracle%2010g%2C11g. :@website:
   Source:  [[https%253A%252F%252Fgithub.com%252FCruiserX%252Fsha256_plsql][CruiserX%2Fsha256_plsql%3A%20SHA256%20PL%2FSQL%20Implementation%20for%20Oracle%2010g%2C11g.]], [2019-03-07 jeu. 23:36]
   #+begin_quote
 SHA256%20PL%2FSQL%20Implementation%20for%20Oracle%2010g%2C11g.%20
   #+end_quote
#+end_example

I think that one possible fix could be to rollback one part of the git commit #cc7c4a673 like
in the patch bellow.

What do you think ?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix org-protocol unescape --]
[-- Type: text/x-patch, Size: 488 bytes --]

diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
index f3e7281ee..d9fdef00e 100644
--- a/lisp/org-protocol.el
+++ b/lisp/org-protocol.el
@@ -381,7 +381,7 @@ If INFO is already a property list, return it unchanged."
 	  (while data
 	    (setq result
 		  (append result
-			  (list (pop data) (pop data)))))
+			  (list (pop data) (org-link-unescape (pop data))))))
 	  result)
       (let ((data (org-protocol-split-data info t org-protocol-data-separator)))
 	(if default-order

[-- Attachment #3: Type: text/plain, Size: 9 bytes --]


Pierre.

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-03-10 17:23 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-07 22:48 [PATCH] Possible bug in org-protocol Pierre Téchoueyres
2019-03-08  8:11 ` Nicolas Goaziou
2019-03-08 18:25   ` Pierre Téchoueyres
2019-03-09 10:14     ` Nicolas Goaziou
2019-03-09 13:14       ` Pierre Téchoueyres
2019-03-10 10:10         ` Nicolas Goaziou
2019-03-10 16:57           ` Pierre Téchoueyres
2019-03-10 17:23             ` Nicolas Goaziou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).