From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KGB1EZ5PMGMpTAAAbAwnHQ (envelope-from ) for ; Sun, 25 Sep 2022 14:54:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6NxbEZ5PMGN+KgAAauVa8A (envelope-from ) for ; Sun, 25 Sep 2022 14:54:54 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E78FD27746 for ; Sun, 25 Sep 2022 14:54:53 +0200 (CEST) Received: from localhost ([::1]:47312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocR9n-0000Mc-N6 for larch@yhetil.org; Sun, 25 Sep 2022 08:54:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocQYW-0004YL-DY for emacs-orgmode@gnu.org; Sun, 25 Sep 2022 08:16:21 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]:38864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ocQYU-0004Pl-A5; Sun, 25 Sep 2022 08:16:19 -0400 Received: by mail-pj1-x102d.google.com with SMTP id x1-20020a17090ab00100b001fda21bbc90so9994016pjq.3; Sun, 25 Sep 2022 05:16:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=rImNiY4s9p0l8SdHpQGJFcV79CFurQ5Gl/3JcYvRGSs=; b=E4TLoXKa6uP1JsBH6JhjtzPf1kSd1So4FDZYPJ/gStCLIYutAZ6oycgU3kKpe6PVT6 4sgGXbLHU4qi8RVFghzoXLyK1yQuZq2Ej7iQgN5bN8v82xHUKApicUNHo3eg+x282Xhg YkkX4/ZrX6EybINghJ/cABf8QD5hPiuQd8MYZKhv4aiz2HFClaVeaHOYEQOOf1Iru6zW xk+HA+/0AeVTIkPviKceX5WCgblu+tTuUiH+DSvMRywzSLgQpCcIspb2+Qj0+GO61fh+ q50x72vlQXihvDMmXfyqp2ih14N6XEv74XK8yoISMGv1M2Q76Xa+ovQW9KZtBizEW6dk 6zuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=rImNiY4s9p0l8SdHpQGJFcV79CFurQ5Gl/3JcYvRGSs=; b=Xa83J0lIRhda1xqzIfpf5ZwiC2Dch244twHNv66QmgLyJUKT2JcaFSkORaco4eFETl f+VLmtt98o9sqmPzfEHjsGH9C3pnsmq689jxwq8W6P+5XrXA0GcOClVuNHlMUbiW4LQY HO68c5QcPyFmhIOhcMvlqC1YpbvvWYuCXcIxPdm2+at48VkI9wZDU9LNZKptR1ZDUOtw AR0tb3VPMv+ZvRymbdvQSWdpNW3Mgi7NDI53L0gSp4aKkU0hsqGwPuUMcpRYshqJe9Qi aNVIgtiOeDNwOmizNufAPkJjIOMbuWmZg6RHRounkEFfantb3fRpETbFUlUbvS7R0eim hWUg== X-Gm-Message-State: ACrzQf2boiWFozFCxCHw9yyV0p7P3gxo7lqpdO45CJxc/09cVC6wiI42 +qiv9ldKsDzQYQtnmjYNTSJ5TT4y/fV5iA== X-Google-Smtp-Source: AMsMyM5IEkgXpLqaC3f6w7woz2SMUMSJZZZhNlDfeIcIj/lEwf7QlVYJhqjLG9aQuX/qPaaZS7JF7w== X-Received: by 2002:a17:902:820a:b0:178:456e:138 with SMTP id x10-20020a170902820a00b00178456e0138mr17095631pln.145.1664108175282; Sun, 25 Sep 2022 05:16:15 -0700 (PDT) Received: from localhost ([2409:8970:a80:3a4:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id z25-20020aa79599000000b005361f6a0573sm9847389pfj.44.2022.09.25.05.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Sep 2022 05:16:14 -0700 (PDT) From: Ihor Radchenko To: Bastien Cc: Stefan Monnier , emacs-orgmode@gnu.org Subject: Re: org-assert-version considered harmful In-Reply-To: <87czbjelux.fsf@gnu.org> References: <875yhsujkq.fsf@localhost> <87h71ct10n.fsf@localhost> <87tu5bbajh.fsf@localhost> <87r10ey8ov.fsf@localhost> <87o7v4dvon.fsf@gnu.org> <874jww16w3.fsf@localhost> <87pmfjpzfw.fsf@bzg.fr> <871qrzsrqd.fsf@localhost> <8735cfn44v.fsf@gnu.org> <87v8pbr9ov.fsf@localhost> <87czbjelux.fsf@gnu.org> Date: Sun, 25 Sep 2022 20:16:55 +0800 Message-ID: <87sfkfr6mg.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=yantar92@gmail.com; helo=mail-pj1-x102d.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664110493; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rImNiY4s9p0l8SdHpQGJFcV79CFurQ5Gl/3JcYvRGSs=; b=NSk1Cwsa3h0e7dVZsYhO3eDwgeGZ04YIx9HeEMd/PeP3HMYwnnRDsXMPuARZsNRXUek+iI tA0Til6soL90Ca5py4NJConeHvWNLhXKu/WxsvC9aSlvMI6wN/NPoFJjxcrXs+EkuYvMnT EPMuuKqPQGAcckTc195kRoS5FvQDdmxYwiXnGxpAoH9tG1c9Cul47ILCkAlo+fpexC/xhj b5rc3Hm56Os7Vkn/p3NMqlyAoiMtCxsTP6d7VngimNlKbDeFMxL/a18kN0TYxQVmG2qVaL aSNAkxq9QoXCfK66DjOD5N2VqDOVRJWglvNUmEfYbkt7TP9epLX298VMLdTHrQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664110494; a=rsa-sha256; cv=none; b=MCChOZIVSXJaH+Sf3D1SEtx+z2h4wzwzf95tTSdtRSiFhaVgpYBHLt9XheELi5MQZbL8x4 MxsxSNQ1m5FELW4pPGYjVIDsVaDoISzvaN4Hca3hQ1WwITaCsO22fTc+Pj5pRCMmwzRgrE 8fBzamr2iiaRKROu7N3VbXMenVF77ZZnveBaeFgF+0CmSbr4VPElp2qdcH2/JiwufGfTyp LBugfsqr2H17nU4DIq/lt8PwnVOLh00EQuK9V4AFA1nQhQ+GzgsmsNAf9Sd3V6qvgYxl7j /bWQxHnmH+YKUMh83XLr57WD2dbgDhaZ6LWJp2meFTh5qmUFwwZt/bSq/569MA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=E4TLoXKa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.85 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=E4TLoXKa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E78FD27746 X-Spam-Score: -1.85 X-Migadu-Scanner: scn1.migadu.com X-TUID: XYg8Z2GwKgKK Bastien writes: >> The code I quoted explicitly removes the "-dev" part. Would you prefer >> to keep it? > > Yes, let's keep it, otherwise (org-release) reads like a lie. > > Why is it necessary to emit org-version.el? > > We could have (defun org-version ...) and (defun org-git-version ...) > from within org.el, right? org-version is already defined in org.el (using org-git-version and org-release) org-git-version requires running git. org-release could be defined in org.el > Also, I don't think we need org-release: the info org-version provides > is enough to know if you are loading Org from a stable (ELPA) release > or from a local git repository. > > WDYT? They are not the same. org-git-version uses tags + HEAD. org-release uses lisp/org.el (after the patch). Also, they are used by Makefile to generate orgcard.tex We need to be careful in this area. This Makefile + Elisp usage is what makes me uncomfortable changing things in this area. >> See the attached. > > Tested and works fine, modulo the -dev part that we should keep. Note that in Org mode version 9.6 (release_9.5.5-830-g77f9e1 @ [load-path]) release_9.5.5 while version is 9.6 I feel like you missed this detail. -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92