[BUG] demarcate block splits block even when outside of src-block

[BUG] demarcate block splits block even when outside of src-block

[dalanicolai]

[-- Attachment #1: Type: text/plain, Size: 4266 bytes --]

 [9.5.4 (release_9.5.4 @ /usr/local/share/emacs/29.0.50/lisp/org/)]

When trying to create a new src-block via `M-x
org-babel-demarcate-block` immediately after a previous code block (only
empty lines in between), then the command behaves like when splitting a
src-block (inserting an #+end_src first, followed by a #+begin_src).

However, as the point is outside of the source block, according to the
docstring of the command, a new source block should be created.

As a comment, normally when creating a new source block, Emacs prompts
for the source block type. However, currently, when used as mentioned
here, the command automatically sets the type (because it tries to
split). I would say that is convenient behavior, so that effectively
only the order of the inserted lines should get reversed.

In any case, thanks for the amazing work!

Emacs  : GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.34, cairo version 1.17.6)
 of 2022-06-12
Package: Org mode version 9.5.4 (release_9.5.4 @
/usr/local/share/emacs/29.0.50/lisp/org/)

current state:
==============
(setq
 org-link-elisp-confirm-function 'yes-or-no-p
 org-bibtex-headline-format-function #[257 "\300\236A\207" [:title] 3
"\n\n(fn ENTRY)"]
 org-export-before-parsing-hook '(org-attach-expand-links)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
 org-cycle-show-empty-lines
 org-optimize-window-after-visibility-change)
 org-mode-hook '(#[0 "\300\301\302\303\304$\207"
  [add-hook change-major-mode-hook org-show-all append local]
  5]
#[0 "\300\301\302\303\304$\207"
  [add-hook change-major-mode-hook org-babel-show-result-all
   append local]
  5]
org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-confirm-shell-link-function 'yes-or-no-p
 outline-isearch-open-invisible-function 'outline-isearch-open-invisible
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
    org-src-mode-configure-edit-buffer)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-speed-command-hook '(org-speed-command-activate
 org-babel-speed-command-activate)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe
     org-babel-header-arg-expand)
 org-link-shell-confirm-function 'yes-or-no-p
 org-babel-pre-tangle-hook '(save-buffer)
 org-agenda-loop-over-headlines-in-active-region nil
 org-occur-hook '(org-first-headline-recenter)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-link-parameters '(("attachment" :follow org-attach-follow :complete
org-attach-complete-link)
      ("id" :follow org-id-open)
      ("eww" :follow org-eww-open :store org-eww-store-link)
      ("rmail" :follow org-rmail-open :store
org-rmail-store-link)
      ("mhe" :follow org-mhe-open :store org-mhe-store-link)
      ("irc" :follow org-irc-visit :store org-irc-store-link
:export org-irc-export)
      ("info" :follow org-info-open :export org-info-export
:store org-info-store-link)
      ("gnus" :follow org-gnus-open :store
org-gnus-store-link)
      ("docview" :follow org-docview-open :export
org-docview-export :store org-docview-store-link)
      ("bibtex" :follow org-bibtex-open :store
org-bibtex-store-link)
      ("bbdb" :follow org-bbdb-open :export org-bbdb-export
:complete org-bbdb-complete-link :store
org-bbdb-store-link)
      ("w3m" :store org-w3m-store-link)
      ("doi" :follow org-link-doi-open :export
org-link-doi-export)
      ("file+sys") ("file+emacs")
      ("shell" :follow org-link--open-shell)
      ("news" :follow
#[514 "\301\300\302Q\"\207"
 ["news" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("mailto" :follow
#[514 "\301\300\302Q\"\207"
 ["mailto" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("https" :follow
#[514 "\301\300\302Q\"\207"
 ["https" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("http" :follow
#[514 "\301\300\302Q\"\207"
 ["http" browse-url ":"] 6 "\n\n(fn URL ARG)"]
)
      ("ftp" :follow
#[514 "\301\300\302Q\"\207" ["ftp" browse-url ":"]
 6 "\n\n(fn URL ARG)"]
)
      ("help" :follow org-link--open-help :store
org-link--store-help)
      ("file" :complete org-link-complete-file)
      ("elisp" :follow org-link--open-elisp))
 org-metaup-hook '(org-babel-load-in-session-maybe)
 )

[-- Attachment #2: Type: text/html, Size: 5479 bytes --]

Re: [BUG] demarcate block splits block even when outside of src-block

[Ihor Radchenko]

dalanicolai <dalanicolai@gmail.com> writes:

>  [9.5.4 (release_9.5.4 @ /usr/local/share/emacs/29.0.50/lisp/org/)]
>
> When trying to create a new src-block via `M-x
> org-babel-demarcate-block` immediately after a previous code block (only
> empty lines in between), then the command behaves like when splitting a
> src-block (inserting an #+end_src first, followed by a #+begin_src).
>
> However, as the point is outside of the source block, according to the
> docstring of the command, a new source block should be created.
>
> As a comment, normally when creating a new source block, Emacs prompts
> for the source block type. However, currently, when used as mentioned
> here, the command automatically sets the type (because it tries to
> split). I would say that is convenient behavior, so that effectively
> only the order of the inserted lines should get reversed.

Thanks for reporting!
Fixed on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=cd835dcad87bc5b3855832449188dd007fce115c

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] demarcate block splits block even when outside of src-block

[dalanicolai]

[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]

Great! Thank you...

On Tue, 25 Oct 2022 at 11:41, Ihor Radchenko <yantar92@posteo.net> wrote:

> dalanicolai <dalanicolai@gmail.com> writes:
>
> >  [9.5.4 (release_9.5.4 @ /usr/local/share/emacs/29.0.50/lisp/org/)]
> >
> > When trying to create a new src-block via `M-x
> > org-babel-demarcate-block` immediately after a previous code block (only
> > empty lines in between), then the command behaves like when splitting a
> > src-block (inserting an #+end_src first, followed by a #+begin_src).
> >
> > However, as the point is outside of the source block, according to the
> > docstring of the command, a new source block should be created.
> >
> > As a comment, normally when creating a new source block, Emacs prompts
> > for the source block type. However, currently, when used as mentioned
> > here, the command automatically sets the type (because it tries to
> > split). I would say that is convenient behavior, so that effectively
> > only the order of the inserted lines should get reversed.
>
> Thanks for reporting!
> Fixed on main.
>
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=cd835dcad87bc5b3855832449188dd007fce115c
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>

[-- Attachment #2: Type: text/html, Size: 2265 bytes --]