emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Mati <mati@electrum-bikes.pl>
Cc: emacs-orgmode@gnu.org
Subject: Re: [O] Maxima code blocks does not work in windows revisited
Date: Wed, 02 Nov 2022 04:47:45 +0000	[thread overview]
Message-ID: <87sfj2kln2.fsf@localhost> (raw)
In-Reply-To: <7d4bfdf1-b210-c90c-9448-703939764fe0@electrum-bikes.pl>

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

Mati <mati@electrum-bikes.pl> writes:

> On 01.11.2022 09:04, Ihor Radchenko wrote:
>
>> Do you mean that you changed the code at line 82 inside
>> org-babel-execute:maxima to
>>
>>   (let* ((cmdline (or (cdr (assoc :cmdline params)) ""))
>> 	  (in-file (org-babel-temp-file "maxima-" ".max"))
>> 		(cmd (format "%s --very-quiet -r \"batchload(\\\"%s\\\")$\" %s"
>> 			     org-babel-maxima-command in-file cmdline)))
>>
>> ??
>>
>> (for reference, this email is a followup of
>> https://orgmode.org/list/CA+ikm3wqA33xP4c3pVV+F2a-gn0dbEzsdx6Vf2cRd+37+u6pBA@mail.gmail.com)
>
> yes, of course only part of it

Ok. Does the attached patch work for you?

> I am testing maxima-mode now (not in org) and it works, but is broken on 
> windows. Looks like there are many more problems with syntax.

Org support for Maxima does not require maxima-mode to be installed,
except for optional fontification.

Note that we can only help with within Org scope. We cannot freely modify
Maxima code.

It will be more productive if you contact Maxima developers on the
issue. They do have a mailing list:
https://maxima.sourceforge.io/maximalist.html#discussion


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ob-maxima-Add-extra-quotes-to-Maxima-cmd-for-Windows.patch --]
[-- Type: text/x-patch, Size: 1303 bytes --]

From 4c1faea44cbe97e53ffb4f78829b86e0da606417 Mon Sep 17 00:00:00 2001
Message-Id: <4c1faea44cbe97e53ffb4f78829b86e0da606417.1667364311.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Wed, 2 Nov 2022 12:43:35 +0800
Subject: [PATCH] ob-maxima: Add extra quotes to Maxima cmd for Windows
 compatibility

* lisp/ob-maxima.el (org-babel-execute:maxima): Add extra quoting
apparently needed to make cmd line work on Windows.

Reported-by: Juan Alvaro Fuentes <juanalvaro.fuentes@upct.es>
Link: https://orgmode.org/list/CA+ikm3wqA33xP4c3pVV+F2a-gn0dbEzsdx6Vf2cRd+37+u6pBA@mail.gmail.com
---
 lisp/ob-maxima.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/ob-maxima.el b/lisp/ob-maxima.el
index dba12d7b6..52423db18 100644
--- a/lisp/ob-maxima.el
+++ b/lisp/ob-maxima.el
@@ -84,7 +84,7 @@ (defun org-babel-execute:maxima (body params)
 		(cmd (format "%s --very-quiet -r %s$ %s"
 			     org-babel-maxima-command
                              (shell-quote-argument
-                              (format "batchload(%S)" in-file))
+                              (format "\"batchload(\\\"%S\\\")\"" in-file))
                              cmdline)))
 	   (with-temp-file in-file (insert (org-babel-maxima-expand body params)))
 	   (message cmd)
-- 
2.35.1


[-- Attachment #3: Type: text/plain, Size: 224 bytes --]


-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

  parent reply	other threads:[~2022-11-02  4:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-01  7:45 [O] Maxima code blocks does not work in windows revisited Mati
2022-11-01  8:04 ` Ihor Radchenko
2022-11-01 10:34   ` Mati
2022-11-01 17:42     ` Leo Butler
2022-11-01 21:14       ` Mati
2022-11-02  4:47     ` Ihor Radchenko [this message]
2022-11-02  7:35       ` Mati
2022-11-02  7:44         ` Ihor Radchenko
     [not found]           ` <7b358b1a-95d8-4733-5a44-4e6e4c782d8f@electrum-bikes.pl>
     [not found]             ` <87eduk8tas.fsf@localhost>
2022-11-03 11:39               ` Mati
2022-11-02 15:17       ` Max Nikulin
2022-11-02 20:11         ` Leo Butler
2022-11-03  2:35           ` Max Nikulin
2022-11-03 10:01             ` Fraga, Eric
2022-11-03 15:54               ` Max Nikulin
2022-11-03 16:09                 ` [PATCH] " Leo Butler
2022-11-06  2:54                   ` Ihor Radchenko
2022-11-07 15:04                     ` Leo Butler
2022-11-03  6:08         ` Ihor Radchenko
2022-11-03  6:09         ` Ihor Radchenko
  -- strict thread matches above, loose matches on Subject: below --
2022-10-31 22:00 [O] " ELECTRUM BIKES

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfj2kln2.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=mati@electrum-bikes.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).