From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gMSmLcP0omNhKQEAbAwnHQ (envelope-from ) for ; Wed, 21 Dec 2022 12:57:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8IzILcP0omNtgQEAauVa8A (envelope-from ) for ; Wed, 21 Dec 2022 12:57:55 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 109C41CB1C for ; Wed, 21 Dec 2022 12:57:54 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7xiQ-0005p9-Do; Wed, 21 Dec 2022 06:56:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7xiO-0005ot-6m for emacs-orgmode@gnu.org; Wed, 21 Dec 2022 06:56:52 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7xiM-0000Bk-64 for emacs-orgmode@gnu.org; Wed, 21 Dec 2022 06:56:51 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3BF56240026 for ; Wed, 21 Dec 2022 12:56:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1671623807; bh=3izlaAxapCDx0AR1oAHzRsSwI4DZmtRC++psUQaQqug=; h=From:To:Cc:Subject:Date:From; b=Y+C7pV0NDMbxgll4RhoRLG/SO4DuKk9p4+yGmMgnaZ0+hv2VUeu9y3P96AAEzjl2k MckpQk99eeEwx/vq3Wk9I5J/B6i6eif/XY8Re32w6dlhxcFwgtxzyeozxHZUMJ5VjR BOB8umYOFhIaEVKso4Rw8M8/GLdZaKuYSteINKIFl2OOr+qMxoiRGbkbHoiCI9JEv3 qeZcIOp+l+hltkft3RO/eeEXWJXZoR7cjTac3dKwWJsZ8Pe9dRENhWbFgCJq42tGws jfKObHESLraOMvUqRZ0dNfhHqLYNAcdl8qRyUZayyGJbJYeRRpqvTHuJvy35IRr8hb zT0vlGCJ0d3ew== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NcX3c26vcz9rxD; Wed, 21 Dec 2022 12:56:44 +0100 (CET) From: Ihor Radchenko To: Leo Butler Cc: Org Mode Mailing List Subject: Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects In-Reply-To: <87cz8ifioa.fsf@localhost> References: <87mt92elyy.fsf@t14.reltub.ca> <87mt9128sz.fsf@localhost> <87zgd1b4rn.fsf_-_@t14.reltub.ca> <8735asbtfe.fsf@localhost> <87pmdvamwf.fsf@t14.reltub.ca> <87bkpaguy3.fsf@localhost> <87leocuhpg.fsf@t14.reltub.ca> <87359esah2.fsf@localhost> <87cz8ifioa.fsf@localhost> Date: Wed, 21 Dec 2022 11:56:42 +0000 Message-ID: <87sfh9vukl.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671623875; a=rsa-sha256; cv=none; b=MzygRxo0Rs5g9H6MNCQPMJKUBl6Z2ykFTsPtzNZSezER6xgD8L/IkXv9pv62lgUuYubP2G nLLl5pyNroP4IlTQzSv5OIusJHgeGM0bqjTnq/s6YFIqM821SqBZS8GLYF99XZNAZ8w+9v CMgbcuAwZI6FEJN9+jTawXb+yBiFpYO/FzSBYn6XghOrDsTI1jByKZ9UBiSpP37SoUyvIM 52M+zKLyVdTl2pIZmvHIqCnB6wZSTN+c+S8ZIDXpufok5pVa7/oN0AMUjYx11F9IrTmJU+ 2vcuAArgK7Cfr+pSE3ORJTg6IwRZ5YXF/ooKVmGkhRbCz0e9Um9KpTAjb/klGQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Y+C7pV0N; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671623875; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gMV5zfP9cSsDkI5SiXqhvDrtA4IZk/Ol7Xoym8vDg2U=; b=pTrQQyhVPXtrg/QM7Msy8tsNiOXlViB3uBycLQYQ34LA1pMecqnoo6rRiw13Luy8PgkOD0 R0uhXVVUtqME6VkIxhHWezOSvaKZ2FR4tXhKtAu+DYEZkyoWTzSYB+C2BgWRX3jDlp+kKV uBe9khtcChzNpWtEAV01xGtQk2bHD1vX6g82wsFh5KwLCkkqiDXhHVx97PLuVIbaHTdz7T 7bSFyQ44QnaOUa79BdwY/erfI5B8UGQVA9TZZzm6TWpRrwOQwCQhFQDlPZsRnKgGIkdoWQ clcmE3xWLkWqnHPrYX/WJCiUx/maciEhO0FbQKY6i6fRMGEhaUEMM4baTnZ+wg== X-Spam-Score: -8.57 X-Migadu-Queue-Id: 109C41CB1C Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Y+C7pV0N; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -8.57 X-TUID: 9o4hT8eJr4Ri Ihor Radchenko writes: >> Upon confirming the FSF copyright assignment, I have applied the patch >> onto bugfix. >> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=01c0ebee2 > > Your patch appears to not work in some environments: > > https://builds.sr.ht/~bzg/job/906710 > > Any ideas? Note that the tests are failing only partially. The graphics file does get created, but it has 0 size for some reason. Maybe something to do with non-graphical CI environment. I disabled the tests for the time being until we figure out what is going on. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=a29103a78 -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at